-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement JSON.OBJLEN command functionality #2484
base: release-1.2
Are you sure you want to change the base?
Conversation
0821b79
to
90fdb6f
Compare
Signed-off-by: BoazBD <[email protected]>
Signed-off-by: BoazBD <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changelog entry
If multiple objects match the path, the length of the first object is returned. | ||
If a value matching the path is not an object, an error is raised. | ||
|
||
Examples: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please show example without path and describe what happens if no path given
|
||
len = await json.objlen(glide_client, key, "..b") | ||
assert len == 3 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test without path
You need to push your branch to this repo (not to your fork) in order to get CI for modules running. |
Issue link
This Pull Request is linked to issue (URL): 2412
Checklist
Before submitting the PR make sure the following are checked: