Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JSON.OBJLEN command functionality #2484

Open
wants to merge 2 commits into
base: release-1.2
Choose a base branch
from

Conversation

BoazBD
Copy link

@BoazBD BoazBD commented Oct 21, 2024

Issue link

This Pull Request is linked to issue (URL): 2412

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@BoazBD BoazBD changed the base branch from main to release-1.2 October 21, 2024 13:54
@BoazBD BoazBD force-pushed the json.objlen branch 3 times, most recently from 0821b79 to 90fdb6f Compare October 21, 2024 14:20
@BoazBD BoazBD marked this pull request as ready for review October 21, 2024 14:25
@BoazBD BoazBD requested a review from a team as a code owner October 21, 2024 14:25
BoazBD added 2 commits October 21, 2024 14:27
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry

If multiple objects match the path, the length of the first object is returned.
If a value matching the path is not an object, an error is raised.

Examples:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please show example without path and describe what happens if no path given


len = await json.objlen(glide_client, key, "..b")
assert len == 3

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test without path

@Yury-Fridlyand
Copy link
Collaborator

You need to push your branch to this repo (not to your fork) in order to get CI for modules running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants