Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print logs when the cluster state changes to fail or the fail reason changes #1188

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

enjoy-binbin
Copy link
Member

This log allows us to easily distinguish between full coverage and
minority partition when the cluster fails. Sometimes it is not easy
to see the minority partition in a healthy shards (both primary and
replicas).

…changes

This log allows us to easily distinguish between full coverage and
minority partition when the cluster fails. Sometimes it is not easy
to see the minority partition in a healthy shards (both primary and
replicas).

Signed-off-by: Binbin <[email protected]>
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.67%. Comparing base (701ab72) to head (5d1380b).
Report is 1 commits behind head on unstable.

Files with missing lines Patch % Lines
src/cluster_legacy.c 92.85% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1188      +/-   ##
============================================
+ Coverage     70.47%   70.67%   +0.19%     
============================================
  Files           114      114              
  Lines         61799    63086    +1287     
============================================
+ Hits          43555    44584    +1029     
- Misses        18244    18502     +258     
Files with missing lines Coverage Δ
src/cluster_legacy.c 86.27% <92.85%> (+0.27%) ⬆️

... and 92 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant