Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMake build system for valkey #1196

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from
Open

Add CMake build system for valkey #1196

wants to merge 2 commits into from
+959 −1

Commits on Oct 20, 2024

  1. Added CMake build system 

    Signed-off-by: Eran Ifrah <[email protected]>
    @eifrah-aws
    eifrah-aws committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f06b624 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Addressed PR comments 

    - Force function names to lowercase in YAML config file
- Parse version from version.h instead of hard-coding it
- Fixed typo
- Moved utility functions into their own module `Utils.cmake`
- macOS: do not hard code "/usr/bin/clang", instead use `find_program`
- Support for WITH_TLS=module|yes|off|1|0
- Support for WITH_RDMA=module|off|0
- Fixed (never worked for the original Makefile as well): build TLS as module on macOS

Signed-off-by: Eran Ifrah <[email protected]>
    @eifrah-aws
    eifrah-aws committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9e53867 View commit details
    Browse the repository at this point in the history