Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce derive_eq option #20

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

introduce derive_eq option #20

wants to merge 1 commit into from

Conversation

valsteen
Copy link
Owner

@valsteen valsteen commented Aug 7, 2023

TODO

  • test
  • doc

questions:

  • derive_hash option ?
  • separately mark fields for hash and eq ? - #[sort_by] becomes a wildcard, introduce top-level and per-field #[hash], #[eq] , #[partial_eq], #[ord], #[partial_ord]

@jayvdb
Copy link

jayvdb commented Nov 19, 2023

ping @valsteen , will you be able to finish this?

@valsteen
Copy link
Owner Author

valsteen commented Nov 19, 2023

@jayvdb hey thanks for giving interest in this project ! I'm getting lost in other non-programming side-projects but here is the struggle I faced when starting this: for consistency, I think all of Eq, PartialEq, Ord, PartialOrd and Hash should have such opt-out option ; but the syntax I started with seems to be a dead end, I feel like I have to break compatibility. Or introduce a guesswork in the parsing so the old ( current ) way still works. Any fresh idea welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants