-
-
Notifications
You must be signed in to change notification settings - Fork 59
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for MySQL's DROP INDEX syntax (#149)
* While SQLite has no DROP INDEX statement at all and PostgreSQL treats indexes as schema-global objects, MySQL's DROP INDEX statement (which is mapped to ALTER TABLE internally) requires specifying the table the index exists on. Rather than try to further complicate the logic for ALTER TABLE, add support for `DROP INDEX ... ON ...` to SQLDropIndex and SQLDropIndexBuilder. In the future, whether or not the owner gets serialized should be guarded by a SQLDialect switch (same as IF EXISTS). * The behavior of `SQLDataType.type(_:)` is not correct in all dialects and can not be safely fixed. It was also only ever a utility method used by a single test and was never intended to be public API at all. Explicitly deprecate it to curtail incorrect usage and update the one call site to stop using it. * Switch to reusable workflow for unit tests, heavily update integration test, add workflow to build code coverage on main
- Loading branch information
Showing
7 changed files
with
91 additions
and
84 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
name: Update code coverage baselines | ||
on: | ||
push: { branches: [ main ] } | ||
jobs: | ||
update-main-codecov: | ||
uses: vapor/ci/.github/workflows/run-unit-tests.yml@reusable-workflows | ||
with: | ||
with_coverage: true | ||
with_tsan: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters