Improve GitHub Checks

vcamapp · Oct 18, 2023 · 48920c2 · 48920c2
1 parent e489391
commit 48920c2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -30,8 +30,14 @@ jobs:
 
   test-ui-preview:
     runs-on: macOS-13
+    permissions:
+      checks: write
 
     steps:
       - uses: actions/checkout@main
-      - name: Build
+      - name: UI test
         run: set -o pipefail && make test-ui-preview | xcpretty
+      - uses: kishikawakatsumi/xcresulttool@v1
+        with:
+          path: /tmp/UITestResults.xcresult
+        if: success() || failure()
diff --git a/Makefile b/Makefile
@@ -7,5 +7,5 @@ build-ui-preview:
 	cd app/xcode/App && xcodebuild -project VCam.xcodeproj -scheme VCamUIPreview -derivedDataPath /tmp/build clean build
 
 test-ui-preview:
-	cd app/xcode/App && xcodebuild -project VCam.xcodeproj -scheme VCamUIPreviewUITests -derivedDataPath /tmp/build test CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO
+	cd app/xcode/App && xcodebuild -project VCam.xcodeproj -scheme VCamUIPreviewUITests -derivedDataPath /tmp/build -resultBundlePath /tmp/UITestResults test CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO CODE_SIGNING_ALLOWED=NO
 
diff --git a/app/xcode/App/VCamUIPreviewUITests/VCamUIPreviewUITests.swift b/app/xcode/App/VCamUIPreviewUITests/VCamUIPreviewUITests.swift
@@ -30,7 +30,7 @@ final class VCamUIPreviewUITests: XCTestCase {
         }
 
         XCTContext.runActivity(named: "Check VCamUI") { _ in
-            XCTAssertTrue(app.buttons["Main"].exists)
+            XCTAssertTrue(app.buttons[L10n.main.text].exists)
         }
     }
 }