Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hardhat tests running on Solo #22

Merged
merged 67 commits into from
Aug 26, 2024
Merged

fix: Hardhat tests running on Solo #22

merged 67 commits into from
Aug 26, 2024

Conversation

freemanzMrojo
Copy link
Member

Closes #18 . The tests now are running on Thor Solo and are part of the PR pipeline.

@freemanzMrojo
first commit
7323710
@freemanzMrojo
first commit
a5e58e3
@freemanzMrojo
some tests fixed
a720ea0
@freemanzMrojo
more tests
c3e6178
@freemanzMrojo
more tests fixed
fc69b65
@freemanzMrojo
added correct chainId for solo
da009f8
@freemanzMrojo
fixed more tests
a5ef094
@freemanzMrojo
removed unneccessary await
7925416
@freemanzMrojo
fix: leaving the code as it was
1e6f80c
@freemanzMrojo
fix: changed entrypoint contract
f9ccc55
@freemanzMrojo
more tests fixed
c3ece2f
@freemanzMrojo
fix: changed entrypoint contract
8132c9b
@freemanzMrojo
fix: small change
76076fa
@freemanzMrojo
fix: getting chainid from a single place
3cfb581
@freemanzMrojo
more tests fixed
e7e2d41
@freemanzMrojo
comment amended
72fb0e6
@freemanzMrojo
more changes
3686b32
@freemanzMrojo
more tests fixed
48cf32c
@freemanzMrojo
more tests fixed
fb2046a
@freemanzMrojo
ci
dca753b
@freemanzMrojo
test
7621b0e
@freemanzMrojo
renamed package scripts for tests
147cef5
@freemanzMrojo
renamed package scripts for tests
2153e97
@freemanzMrojo
removed unused test file since the test is duplicated
a857ddb
@freemanzMrojo
fixed helpers test
d0ceed0
@freemanzMrojo
small change
f8c88c2
@freemanzMrojo
using entrypoint to fund vtho
d86df48
@freemanzMrojo
test cleanup
6fdb1cc
@freemanzMrojo
test cleanup
33f9c76
@freemanzMrojo
fixed another test
4720b9f
@freemanzMrojo freemanzMrojo changed the title [DRAFT] Hardhat tests fixed and running on Solo Hardhat tests fixed and running on Solo Aug 26, 2024
@freemanzMrojo freemanzMrojo marked this pull request as ready for review August 26, 2024 11:22
@freemanzMrojo freemanzMrojo requested a review from a team as a code owner August 26, 2024 11:22
@freemanzMrojo freemanzMrojo changed the title Hardhat tests fixed and running on Solo fix: Hardhat tests and running on Solo Aug 26, 2024
@freemanzMrojo freemanzMrojo changed the title fix: Hardhat tests and running on Solo fix: Hardhat tests running on Solo Aug 26, 2024
vanja-vechain
vanja-vechain approved these changes Aug 26, 2024
View reviewed changes
Copy link

@vanja-vechain vanja-vechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@freemanzMrojo freemanzMrojo merged commit 7d50d00 into vechain Aug 26, 2024
6 checks passed
@freemanzMrojo freemanzMrojo deleted the fix/18-hh-tests branch August 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanja-vechain vanja-vechain vanja-vechain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Hardhat tests
2 participants
@freemanzMrojo @vanja-vechain