-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Swap out mockwatchlogs for localstack #21114
Conversation
Now that localstack supports CloudWatch Logs as a service. Signed-off-by: Jesse Szwedko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-integration-aws
Signed-off-by: Jesse Szwedko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-integration-aws
Datadog ReportBranch report: ✅ 0 Failed, 87 Passed, 0 Skipped, 4m 27.72s Total Time |
Signed-off-by: Jesse Szwedko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-integration-aws
@jszwedko it looks like the problem is just in different order of elements in the arrays.
sorting the arrays might just do the trick, like: |
Trying it in #21140 |
Signed-off-by: balonik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-integration-aws
@jszwedko almost there. those arrays are not defined as mutable 😩
|
I just saw that too :) I'll fix it up. |
Signed-off-by: Jesse Szwedko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ci-run-integration-aws
This looks to be working now. Thanks for the suggestion and the assist @balonik ! |
Regression Detector ResultsRun ID: eb2a607c-c5b1-42f4-98ce-993036cba02a Metrics dashboard Baseline: fe2cc26 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
❌ | file_to_blackhole | egress throughput | -8.64 | [-15.43, -1.86] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +2.10 | [+1.94, +2.27] | |
➖ | http_to_http_acks | ingress throughput | +1.38 | [+0.04, +2.71] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +1.14 | [+1.02, +1.26] | |
➖ | http_elasticsearch | ingress throughput | +0.45 | [+0.26, +0.63] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | +0.34 | [+0.20, +0.48] | |
➖ | http_to_http_noack | ingress throughput | +0.08 | [+0.02, +0.13] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +0.07 | [-0.04, +0.18] | |
➖ | http_to_http_json | ingress throughput | +0.04 | [-0.00, +0.09] | |
➖ | syslog_humio_logs | ingress throughput | +0.03 | [-0.10, +0.15] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.02 | [-0.10, +0.14] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.01 | [-0.07, +0.09] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | +0.00 | [-0.10, +0.10] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.00 | [-0.13, +0.13] | |
➖ | otlp_http_to_blackhole | ingress throughput | -0.05 | [-0.18, +0.08] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | -0.16 | [-0.34, +0.01] | |
➖ | http_to_s3 | ingress throughput | -0.29 | [-0.56, -0.02] | |
➖ | socket_to_socket_blackhole | ingress throughput | -0.45 | [-0.51, -0.39] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -0.51 | [-0.72, -0.29] | |
➖ | http_text_to_http_json | ingress throughput | -0.66 | [-0.84, -0.48] | |
➖ | syslog_splunk_hec_logs | ingress throughput | -0.75 | [-0.87, -0.63] | |
➖ | syslog_loki | ingress throughput | -1.16 | [-1.24, -1.09] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | -1.42 | [-1.54, -1.30] | |
➖ | fluent_elasticsearch | ingress throughput | -1.45 | [-1.93, -0.96] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -1.80 | [-1.90, -1.70] | |
➖ | splunk_hec_route_s3 | ingress throughput | -2.31 | [-2.67, -1.94] | |
❌ | file_to_blackhole | egress throughput | -8.64 | [-15.43, -1.86] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
* chore(ci): Swap out mockwatchlogs for localstack Now that localstack supports CloudWatch Logs as a service. Signed-off-by: Jesse Szwedko <[email protected]> * Enable logs Signed-off-by: Jesse Szwedko <[email protected]> * Fix port Signed-off-by: Jesse Szwedko <[email protected]> * sort arrays when comparing Signed-off-by: balonik <[email protected]> * clippy Signed-off-by: Jesse Szwedko <[email protected]> --------- Signed-off-by: Jesse Szwedko <[email protected]> Signed-off-by: balonik <[email protected]> Co-authored-by: balonik <[email protected]>
Now that localstack supports CloudWatch Logs as a service.
Signed-off-by: Jesse Szwedko [email protected]