Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Properly hand off the proptest feature to vrl #21574

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Oct 21, 2024

When vrl is used through the vector-lib import, there is no direct way of specifying the proptest feature, but that should be activated. This corrects that omission.

When `vrl` is used through the `vector-lib` import, there is no direct way of
specifying the `proptest` feature, but that should be activated. This corrects
that omission.
@bruceg bruceg added type: tech debt A code change that does not add user value. dependencies Pull requests that update a dependency file no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Oct 21, 2024
@bruceg bruceg requested a review from a team as a code owner October 21, 2024 22:27
@bruceg bruceg enabled auto-merge October 21, 2024 22:30
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: bruceg/OPA-2521-hand-off-vrl-proptest-feature
Commit report: 73a9bc7
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.52s Total Time

@bruceg bruceg added this pull request to the merge queue Oct 21, 2024
Copy link

Regression Detector Results

Run ID: 4e43478f-7b02-48d7-9494-92d66fd04771 Metrics dashboard

Baseline: eb699ef
Comparison: 75d59e9

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput +2.11 [-2.05, +6.27]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +2.57 [+2.46, +2.68]
file_to_blackhole egress throughput +2.11 [-2.05, +6.27]
socket_to_socket_blackhole ingress throughput +1.87 [+1.80, +1.95]
datadog_agent_remap_blackhole ingress throughput +1.75 [+1.66, +1.84]
datadog_agent_remap_blackhole_acks ingress throughput +1.62 [+1.51, +1.73]
http_text_to_http_json ingress throughput +0.99 [+0.84, +1.14]
datadog_agent_remap_datadog_logs ingress throughput +0.45 [+0.26, +0.64]
http_to_s3 ingress throughput +0.11 [-0.05, +0.28]
http_to_http_acks ingress throughput +0.03 [-0.45, +0.52]
http_to_http_json ingress throughput +0.00 [-0.05, +0.06]
http_to_http_noack ingress throughput +0.00 [-0.05, +0.05]
splunk_hec_to_splunk_hec_logs_noack ingress throughput +0.00 [-0.02, +0.02]
splunk_hec_indexer_ack_blackhole ingress throughput +0.00 [-0.02, +0.02]
datadog_agent_remap_datadog_logs_acks ingress throughput -0.02 [-0.14, +0.09]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.04 [-0.07, -0.01]
splunk_hec_route_s3 ingress throughput -0.09 [-0.42, +0.24]
http_elasticsearch ingress throughput -0.31 [-0.46, -0.16]
syslog_regex_logs2metric_ddmetrics ingress throughput -0.57 [-0.68, -0.45]
syslog_loki ingress throughput -0.74 [-0.82, -0.66]
otlp_http_to_blackhole ingress throughput -0.86 [-0.94, -0.78]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.94 [-1.03, -0.85]
syslog_splunk_hec_logs ingress throughput -1.08 [-1.18, -0.99]
syslog_log2metric_humio_metrics ingress throughput -1.17 [-1.31, -1.04]
fluent_elasticsearch ingress throughput -1.55 [-2.08, -1.02]
syslog_humio_logs ingress throughput -1.83 [-1.95, -1.72]
otlp_grpc_to_blackhole ingress throughput -4.29 [-4.46, -4.12]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 75d59e9 Oct 22, 2024
74 checks passed
@bruceg bruceg deleted the bruceg/OPA-2521-hand-off-vrl-proptest-feature branch October 22, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-changelog Changes in this PR do not need user-facing explanations in the release changelog type: tech debt A code change that does not add user value.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants