Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: alt.themes -> alt.theme #3618

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

refactor: alt.themes -> alt.theme #3618

wants to merge 52 commits into from

Commits on Sep 28, 2024

  1. chore: Add notes for change targets 

    Need a way to make sense of these and start GH threads:

- 10 total files
- 3 modules named `theme.py`
- 2 modules named `__init__.py`
    @dangotbanned
    dangotbanned committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    54e7e48 View commit details
    Browse the repository at this point in the history

  2. chore: Add TODO in update_init_file.py

    @dangotbanned
    dangotbanned committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    66c51c3 View commit details
    Browse the repository at this point in the history

  3. refactor: Remove altair.vegalite.v5.theme from alt.__all__

    @dangotbanned
    dangotbanned committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    754f665 View commit details
    Browse the repository at this point in the history

  4. refactor: Add alt.theme.py

    @dangotbanned
    dangotbanned committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    3dd9100 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. build(typing): Generate altair.vegalite.v5.schema.__init__.__all__ 

    #3618 (comment)
    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    b1be633 View commit details
    Browse the repository at this point in the history

  2. build: Generate altair.vegalite.v5.__init__.__all__ 

    #3618 (comment)
    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    0bd8f75 View commit details
    Browse the repository at this point in the history

  3. refactor: utils.theme -> vegalite.v5.theme

    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    c996c95 View commit details
    Browse the repository at this point in the history

  4. refactor: Remove alt.typing.theme

    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    c286c38 View commit details
    Browse the repository at this point in the history

  5. refactor: Adds alt.theme implementation

    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    ef9b846 View commit details
    Browse the repository at this point in the history

  6. test: Fix test_common 

    Was dependent on `v5` having the registry exported in `__init__`
    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    e8d3062 View commit details
    Browse the repository at this point in the history

  7. chore(typing): Remove now fix ignore comments 

    #3618 (comment)
    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f7fe38b View commit details
    Browse the repository at this point in the history

  8. fix(typing): Use a bounded TypeVar to support list[str]

    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    0a1c8d3 View commit details
    Browse the repository at this point in the history

  9. refactor: Add deprecation handling alt.__init__.__getattr__

    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    05eca89 View commit details
    Browse the repository at this point in the history

  10. docs: Adds alt.theme to API Reference 

    #3618 (comment)
    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    217d7fb View commit details
    Browse the repository at this point in the history

  11. docs: Add missing altair qualifier for TypedDict(s) 

    https://www.sphinx-doc.org/en/master/usage/domains/python.html#cross-referencing-python-objects
    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    5078f88 View commit details
    Browse the repository at this point in the history

  12. fix(typing): Preserve generics in PluginEnabler

    @dangotbanned
    dangotbanned committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    2339116 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. refactor: Refine and fully document generate_schema__init__ 

    - Require fewer parameters
- Remove need for format string
- Adds general `path_to_module_str` utility

#3618 (comment)
    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    48e44c0 View commit details
    Browse the repository at this point in the history

  2. refactor: Use new functions for part of update__all__variable 

    The rest is still different enough that I'm not planning to further generalize between the two approaches
    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a7dbaca View commit details
    Browse the repository at this point in the history

  3. fix: Don't consider suffix a part in path_to_module_str 

    https://github.com/vega/altair/actions/runs/11108757298/job/30862467326?pr=3618
    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a0947f8 View commit details
    Browse the repository at this point in the history

  4. fix: Account for GH runner path 

    https://github.com/vega/altair/actions/runs/11109202680/job/30863988787?pr=3618
    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1e9f639 View commit details
    Browse the repository at this point in the history

  5. docs: Add link targets for API Reference sections 

    I've paired these with the `toctree` name, except for `api`.
Since that would be `api-api`
    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d895447 View commit details
    Browse the repository at this point in the history

  6. docs: Customize theme toctree order

    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    a9538bc View commit details
    Browse the repository at this point in the history

  7. docs: Update User Guide section 

    #3607
    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    e114493 View commit details
    Browse the repository at this point in the history

  8. docs: Provide API ref link in warning 

    #3618 (comment)
    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    c8033b2 View commit details
    Browse the repository at this point in the history

  9. refactor: Remove unused __future__ import 

    I added this while experimenting with a more complex `__getattr__`, but don't need it for anything in this version
    @dangotbanned
    dangotbanned committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ef0f263 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. feat: Support alt.theme.(active|options) 

    #3610 (comment)
    @dangotbanned
    dangotbanned committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    58da996 View commit details
    Browse the repository at this point in the history

  2. fix(typing): Partial resolve mypy __getattr__ 

    Didn't have any issues with `pyright`.
Adapted from https://stackoverflow.com/a/78369397

https://github.com/vega/altair/actions/runs/11123634307/job/30907482239?pr=3618
    @dangotbanned
    dangotbanned committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    bc507a9 View commit details
    Browse the repository at this point in the history

  3. test: Rename test to test_theme_register_decorator 

    Now reflects the updated function name
    @dangotbanned
    dangotbanned committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e0f4721 View commit details
    Browse the repository at this point in the history

  4. test: Add some more (theme|themes) equal checks

    @dangotbanned
    dangotbanned committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    4e8def0 View commit details
    Browse the repository at this point in the history

  5. test: Add test_theme_unregister 

    The commented out assertion may be added later after resolving #3619
    @dangotbanned
    dangotbanned committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    9bd0316 View commit details
    Browse the repository at this point in the history

  6. feat: Raise instead of returning None in unregister

    @dangotbanned
    dangotbanned committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0d95b44 View commit details
    Browse the repository at this point in the history

  7. docs: Update remaining ThemeRegistry methods

    @dangotbanned
    dangotbanned committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3e6bde8 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch 'main' into refac-alt-theme

    @dangotbanned
    dangotbanned authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6141c7c View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'main' into refac-alt-theme

    @dangotbanned
    dangotbanned authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d1ae98e View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Merge branch 'main' into refac-alt-theme

    @dangotbanned
    dangotbanned authored Oct 5, 2024
    Configuration menu
    Copy the full SHA
    2ca4b11 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Merge branch 'main' into refac-alt-theme

    @dangotbanned
    dangotbanned authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    d3dccab View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. test: Adds test_theme_remote_lambda 

    Related #3618 (comment)
    @dangotbanned
    dangotbanned committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7c49b51 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Merge branch 'main' into refac-alt-theme

    @dangotbanned
    dangotbanned committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    a3e2d28 View commit details
    Browse the repository at this point in the history

  2. docs: Suggest alt.theme instead of alt.theme.themes 

    #3618 (comment)
    @dangotbanned
    dangotbanned committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    a018165 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Merge branch 'main' into refac-alt-theme

    @dangotbanned
    dangotbanned authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    98f4ed3 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge remote-tracking branch 'upstream/main' into refac-alt-theme

    @dangotbanned
    dangotbanned committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4fe4321 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. refactor: Rename theme.themes -> theme._themes 

    #3618 (comment), #3618 (comment), #3610 (comment)
    @dangotbanned
    dangotbanned committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    2b3eb35 View commit details
    Browse the repository at this point in the history

  2. docs: Update @theme.register 

    Rather than saying exactly where `name` is **stored**, showing a place it is **used** with an example
    @dangotbanned
    dangotbanned committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    10872b6 View commit details
    Browse the repository at this point in the history

  3. docs: Update customization.rst 

    - Replaced references to `altair.theme.themes`
- Tried to improve the flow, without entirely removing the term "registry"
    @dangotbanned
    dangotbanned committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1127534 View commit details
    Browse the repository at this point in the history

  4. feat: Add support displaying warning once 

    #3618 (comment), #3618 (comment), #3618 (comment)
    @dangotbanned
    dangotbanned committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    cb56c82 View commit details
    Browse the repository at this point in the history

  5. docs: Adds utils.deprecation.__all__

    @dangotbanned
    dangotbanned committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0977228 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. docs: Add examples to deprecation message 

    #3618 (comment), #3618 (comment)
    @dangotbanned
    dangotbanned committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    5a1dc68 View commit details
    Browse the repository at this point in the history

  2. docs: Prefix `" 

    "` to all deprecation warnings

#3618 (comment), #3618 (comment)
    @dangotbanned
    dangotbanned committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    22d7df2 View commit details
    Browse the repository at this point in the history

  3. docs(typing): Adds static-only deprecation for themes.register 

    #3618 (comment)
    @dangotbanned
    dangotbanned committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    25cbdc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Merge branch 'main' into refac-alt-theme

    @dangotbanned
    dangotbanned authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    e29a2f7 View commit details
    Browse the repository at this point in the history

  2. docs: "Deprecated in" -> "Deprecated since" 

    #3618 (comment), #3618 (comment)
    @dangotbanned
    dangotbanned committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    a0497e0 View commit details
    Browse the repository at this point in the history

  3. docs: Add more specific constraints to @deprecated_static_only 

    The rules here are not the same as the rules for [`LiteralString`](https://typing.readthedocs.io/en/latest/spec/literal.html#literalstring)

Hoping to avoid any confusion if anyone uses this later
    @dangotbanned
    dangotbanned committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    b84fd5f View commit details
    Browse the repository at this point in the history