Skip to content

Commit

Permalink
build: Drop support for python<3.9
Browse files Browse the repository at this point in the history
  • Loading branch information
dangotbanned committed Aug 18, 2024
1 parent 7079db2 commit 4300dbf
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
name: py ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v4
Expand Down
7 changes: 3 additions & 4 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ keywords = [
"altair",
"sphinxext"
]
requires-python = ">=3.8"
requires-python = ">=3.9"
dynamic = ["version"]
license-files = { paths = ["LICENSE"] }
classifiers= [
Expand All @@ -36,7 +36,6 @@ classifiers= [
"License :: OSI Approved :: BSD License",
"Natural Language :: English",
"Framework :: Sphinx :: Extension",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down Expand Up @@ -78,7 +77,7 @@ default-args = ["--numprocesses=logical","--doctest-modules", "tests"]
parallel = true

[[tool.hatch.envs.hatch-test.matrix]]
python = ["3.8", "3.9", "3.10", "3.11", "3.12"]
python = ["3.9", "3.10", "3.11", "3.12"]

[tool.hatch.envs.hatch-test.scripts]
run = [
Expand All @@ -100,7 +99,7 @@ build-html = ["sphinx-build -b html tests/roots/test-altairplot tests/roots/test
serve = ["(cd tests/roots/test-altairplot/_build/html && python -m http.server)"]

[tool.ruff]
target-version = "py38"
target-version = "py39"
line-length = 88
indent-width = 4
exclude = []
Expand Down
16 changes: 4 additions & 12 deletions tests/conftest.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import sys
from pathlib import Path

import pytest

Expand All @@ -8,15 +8,7 @@
# Exclude 'roots' dirs for pytest test collector
collect_ignore = ["roots"]

if sys.version_info >= (3, 9):
from pathlib import Path

@pytest.fixture(scope="session")
def rootdir():
return Path(__file__).parent / "roots"
else:
from sphinx.testing.path import path

@pytest.fixture(scope="session")
def rootdir():
return path(__file__).parent.abspath() / "roots"
@pytest.fixture(scope="session")
def rootdir():
return Path(__file__).parent / "roots"

0 comments on commit 4300dbf

Please sign in to comment.