Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display code that triggered an error in warning #13

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

dangotbanned
Copy link
Member

@dangotbanned dangotbanned commented Sep 3, 2024

Resolves #12

Had to change the original idea, as a warning stacklevel must point to code - but the error code is within an .rst node.

Sample Output

image

@dangotbanned dangotbanned changed the title Fix-warning-stacklevel fix: Display code that triggered an error in warning Sep 3, 2024
Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@binste binste merged commit 777d56e into vega:main Sep 4, 2024
5 checks passed
@dangotbanned dangotbanned deleted the fix-warning-stacklevel branch September 4, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warnings.warn(stacklevel=...) set too low
2 participants