Fix updateName function #313
Open
+707
−535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Supabase AI Clarified documentation for local Supabase setup Updated dependencies
|
@chriscarrollsmith is attempting to deploy a commit to the Vercel Solutions Team on Vercel. A member of the Team first needs to authorize it. |
leerob
reviewed
Mar 11, 2024
| @@ -3,14 +3,15 @@ | |||
| "version": "0.0.0", | |||
| "license": "MIT", | |||
| "scripts": { | |||
| "dev": "next dev --turbo", | |||
There was a problem hiding this comment.
Let's keep this and please share the errors you're seeing! We'd like to fix them. Could you also try on the latest next@canary please?
There was a problem hiding this comment.
Sure. Here's the error:
I'm happy to report that it seems fixed in next@canary, though! Should I update the PR to use that, or should I wait until official release of stable 14.2.0?
Regenerated database types to fix Issue 297 Enhanced README OAuth instructions and added a note on controlling display sequence for Stripe products
|
PR updated as follows:
|
|
Yeah, go ahead and keep |
k-thornton
reviewed
May 10, 2024
| @@ -95,7 +97,7 @@ For example, you can create business models with different pricing tiers, e.g.: | |||
| - Price 1: 20 USD per month | |||
| - Price 2: 200 USD per year | |||
|
|
|||
| Optionally, to speed up the setup, we have added a [fixtures file](fixtures/stripe-fixtures.json) to bootstrap test product and pricing data in your Stripe account. The [Stripe CLI](https://stripe.com/docs/stripe-cli#install) `fixtures` command executes a series of API requests defined in this JSON file. Simply run `stripe fixtures fixtures/stripe-fixtures.json`. | |||
| Optionally, to speed up the setup, we have added a [fixtures file](fixtures/stripe-fixtures.json) to bootstrap test product and pricing data in your Stripe account. The [Stripe CLI](https://stripe.com/docs/stripe-cli#install) `fixtures` command executes a series of API requests defined in this JSON file. Simply run `stripe fixtures fixtures/stripe-fixtures.json`. (Note the use of a numerical index in the product metadata to control display sequence in the UI). | |||
There was a problem hiding this comment.
omg thank you for this note! You just helped me figure out how to sequence my products!
|
You're welcome! :)
…On Fri, May 10, 2024, 2:51 PM Kyle Thornton ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<#313 (comment)>
:
> @@ -95,7 +97,7 @@ For example, you can create business models with different pricing tiers, e.g.:
- Price 1: 20 USD per month
- Price 2: 200 USD per year
-Optionally, to speed up the setup, we have added a [fixtures file](fixtures/stripe-fixtures.json) to bootstrap test product and pricing data in your Stripe account. The [Stripe CLI](https://stripe.com/docs/stripe-cli#install) `fixtures` command executes a series of API requests defined in this JSON file. Simply run `stripe fixtures fixtures/stripe-fixtures.json`.
+Optionally, to speed up the setup, we have added a [fixtures file](fixtures/stripe-fixtures.json) to bootstrap test product and pricing data in your Stripe account. The [Stripe CLI](https://stripe.com/docs/stripe-cli#install) `fixtures` command executes a series of API requests defined in this JSON file. Simply run `stripe fixtures fixtures/stripe-fixtures.json`. (Note the use of a numerical index in the product metadata to control display sequence in the UI).
omg thank you for this note! You just helped me figure out how to sequence
my products!
—
Reply to this email directly, view it on GitHub
<#313 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASCYPGPDDYO2M7HMW6S2CYLZBU6NNAVCNFSM6AAAAABEOTL22OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJQHEYTMOJRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateNamefunction so it changes the public.users table rather than the auth.users table (which was problematic for reasons laid out in the issue)--turboflag fromdevcommand in package.json, which was breaking some dependencies (UPDATE: we're keeping --turbo but updating to next@canary).envor setup will fail)priceData#297: Restores missing types for two columns in thepricestable