[Bison] Raised Minimum Bison Version to 3.3 #2529
Conversation
AlexandreSinger
force-pushed
the
feature-remove-warnings
branch
from
7cac414 to
4aeb2f8
Compare
AlexandreSinger
changed the title
AlexandreSinger
changed the title
|
@vaughnbetz What do you think about this? To prevent having to raise the minimum Bison version to Bison 3.3, I have suppressed the deprecation warning only in the two affected yacc files. I have verified that this fixes the warnings. |
|
This is a good question for the Thursday meeting in my opinion (if you can bring up a quick summary). It is a bit dangerous to suppress a deprecation warning, but I guess it will error if they ever fully deprecate it ... |
|
@vaughnbetz I agree, I think this is a great topic to bring up! However, I will not be at the one this week. I could bring it up next week! I do not think this is very time sensitive. |
|
Two weeks is fine. You could bring up any thorny ones there, plus overall status on getting warning clean. |
AlexandreSinger
force-pushed
the
feature-remove-warnings
branch
from
4aeb2f8 to
85d1862
Compare
AlexandreSinger
changed the title
Raised the minimum Bison version to 3.3 since deprecation warnings were showing up in libblifparse and libsdcparse which could not be resolved unless the Bison version was 3.3.
AlexandreSinger
force-pushed
the
feature-remove-warnings
branch
from
85d1862 to
0de1df1
Compare
Suppressed the Bison deprecation warnings for SDCParse and BlifParse since the fix for the deprecation requires Bison 3.3, but the current minimum version of Bison is 3.0 Some development machines using VPR cannot be upgraded to Bison 3.3 easily, so for now the deprecation warnings are just being suppressed until all machines are on Bison 3.3 PR verilog-to-routing#2529 tracks this issue and contains the code to fix the deprecations.
Suppressed the Bison deprecation warnings for SDCParse and BlifParse since the fix for the deprecation requires Bison 3.3, but the current minimum version of Bison is 3.0 Some development machines using VPR cannot be upgraded to Bison 3.3 easily, so for now the deprecation warnings are just being suppressed until all machines are on Bison 3.3 PR verilog-to-routing#2529 tracks this issue and contains the code to fix the deprecations.
|
Keeping this one around -- will merge once we've updated to a recent enough Ubuntu on CI and all systems we care about. |
Raised the minimum Bison version from 3.0 to 3.3 to handle deprecation warnings.
Description
In recent versions of Bison, the
parser_class_namedirective has been deprecated forapi.parser.class.See issue #2518
The issue is that
api.parser.classwas not introduced until Bison 3.3. Currently the minimum Bison version for libblifparse and libsdcparse is Bison 3.0 (which is the same version we use on our development machines). To properly fix these warnings we would need to raise the minimum Bison version to Bison 3.3 and resolve the deprecation.