fix: v8.0.0 release version on latest machine[Ubuntu 24.04] #2826
Conversation
|
Thanks! We should merge this ... I just need to figure out how to get it tested as our automated CI wasn't nearly as good back in the 8.0 release. If you have a summary of any testing you've done please add it here since it will help move this along. |
|
Adding @AlexandreSinger (since he's so helpful :). |
|
Sorry i didn't have any testing framework , i went into each and every error i received while building and resolved them tested run_vtr_flow.pl basic_flow from tutorial example, The result is "OK" but When i give my custom design file odin_ii is seg faulting for synthesis , i am debugging it now . can you help me , how can i do testing more aggresively and add them |
|
I'm not sure what the issue is, and I doubt anyone from the UNB team will investigate an 8.0 seg fault with Odin II. I suggest upgrading to the latest master branch if you're having a problem with Odin II; it has a lot of upgrades, and is under active development. |
|
Issue is with my verilog code ,it seems like v8 odin II support only 1995, 2001 verilog syntax Everything seems working now , i am able to run my custom designs and I ran regression tests as well |
There was a problem hiding this comment.
Hi @markram1729
As Vaughn mentioned v8.0.0 is not tracked by CI, so we would need to be careful to push changes to it. v8.0.0 was tested on Ubuntu 22.04 at the latest (I think), so that is the oldest version it is recommended on. If you must use Ubuntu 24.04, I recommend using the latest version from the Master branch. I have ensured that the current version on Master runs up to Ubuntu 24.04.
Adding extra include headers should not cause issues (we have made similar changes when we got Ubuntu 24.04 working the first time); however, I am concerned about the modifications to libcatch.
| @@ -6467,7 +6467,7 @@ namespace Catch { | |||
| static bool isSet; | |||
| static struct sigaction oldSigActions [sizeof(signalDefs)/sizeof(SignalDefs)]; | |||
| static stack_t oldSigStack; | |||
| static char altStackMem[SIGSTKSZ]; | |||
| static char altStackMem[32768]; | |||
There was a problem hiding this comment.
Why did you have to remove the SIGSTKSZ variable? This is a system constant that should be available in Ubuntu 24.04. This is also in the labcatch directory which is not maintained by VTR.
There was a problem hiding this comment.
Yes , that is what i expected at start too . it is issue with catch1 this solution they gave as temporary fix for catch 1 and updated the fix in catch2 gracefully
issue is "static char altStackMem[SIGSTKSZ];" expects expression to be constant and to be in compile time
in latest glibc it is "# define SIGSTKSZ sysconf (_SC_SIGSTKSZ)" which loads in runtime due to sysconf syscall
I was using master branch from the start but i happen to use v8 due to other dependancies in my usecase
Just raised this pull request as it is broken in my system and i thought it might be helpful .
Let me know if i can be of any help with adding CI
|
@AlexandreSinger recommends making a new 8.0.0 - ubuntu24.04 branch to store this. Can you do that? We'll merge to that and document it as VTR 8.0 for Ubuntu 24.04. |
|
As Vaughn mentions above, the branch you are merging into is directly following version 8.0.0; which did not support Ubuntu 24.04. We can merge this in, but then this branch would then be ahead of the v8.0.0 release of VTR, which would require us to make another release (v8.0.1?), however we are currently planning for another major release which will overshadow this. A simple solution is making a new branch (vtr8-noble) which people can go to if they want vtr8 + Ubuntu24.04 support. We really appreciate your contribution and want others to be able to benefit from it! We are just being careful with what we call the canonical release of VTR (since we would need to test it rigourously. If you would like, I can create a branch on VTR for this to be merged into! |
|
Sure! |
|
Hi @markram1729 I have created the following branch: It is based off the same branch as yours (8.x), but it is separate so it is separated from the VTR8 release branch. You should be able to rebase onto it without issue and point this PR to it. |
|
hi @AlexandreSinger @vaughnbetz i have raised a pull request base to vtr8-noble, kindly check it |
Description
Related Issue
#2825
Motivation and Context
To fix and run v8.0.0
How Has This Been Tested?
Able to run basic examples in vtr , with separate environment for tbb [oneTBB-2020.3.2]
Types of changes
Checklist: