-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Add pre-commit, drop python 3.8, add python 3.12, add yamllint, add toml-sort #124
Conversation
@vferat Can you go on https://pre-commit.ci/ and enable this CI for this repository? |
Ok, that should do it. I also fixed some MNE 1.6 compatibility issues (again), and I added a linter for |
@vferat This time it should be green. In the end this PR does:
And then.. I decided to turn warnings into errors in I added a GH workflows to help me debug the Azure workflows. The output is cleaner, the configuration file shorter, and the macOS runner faster. I'm inclined to drop the AZP workflows entirely in favor of GH, as MNE did. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more fixes
Hey @mscheltienne, I've activated the pre_commit for this repository. Regarding your suggestion to drop the Azure Pipelines (AZP) workflows in favor of GitHub Actions (GH), I believe it's a solid idea. It can make it easier for contributors to manage our automation, and Ialways happy to reduce reliance on external third-party services. Thanks for your work in this PR, everything else looks good to me ! |
|
What do you mean? GitHub self-hosted runners are unlimited for public repositories.
That should be the last warning to fix, from |
pre-commit
is optional.If you want to use it:
You can run on all files with
pre-commit run --all-files
.If you want to remove it: