Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ecc to zero for failures t/f > tmax/fmax #208

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

md-arif-shaikh
Copy link
Collaborator

Addressing #206. For methods like Amplitude or Frequency, it could be challenging to detect the small oscillations in the later part of the inspiral and therefore the maximum allowed time tmax or frequency fmax could be much smaller than the time/frequency near merger. Therefore, for time/frequency after tmax/fmax, eccentricity can not be measured. If set_failures_to_zero is True, we set the eccentricity/mean anomaly to zero for such cases at these times/frequencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants