docs: simplify TaintBadDataPlugin example again

vimeo · Jan 23, 2024 · bb10f13 · bb10f13
1 parent 8a05e31
commit bb10f13
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/docs/security_analysis/custom_taint_sources.md b/docs/security_analysis/custom_taint_sources.md
@@ -44,11 +44,11 @@ class TaintBadDataPlugin implements AddTaintsInterface
     {
         $expr = $event->getExpr();
 
-        if (!$expr instanceof Variable) {
-            return [];
+        if ($expr instanceof Variable && $expr->name === 'bad_data') {
+            return TaintKindGroup::ALL_INPUT;
         }
 
-        return $expr->name === 'bad_data' ? TaintKindGroup::ALL_INPUT : [];
+        return [];
     }
 }
 ```
diff --git a/tests/Config/Plugin/EventHandler/AddTaints/TaintBadDataPlugin.php b/tests/Config/Plugin/EventHandler/AddTaints/TaintBadDataPlugin.php
@@ -21,10 +21,10 @@ public static function addTaints(AddRemoveTaintsEvent $event): array
     {
         $expr = $event->getExpr();
 
-        if (!$expr instanceof Variable) {
-            return [];
+        if ($expr instanceof Variable && $expr->name === 'bad_data') {
+            return TaintKindGroup::ALL_INPUT;
         }
 
-        return $expr->name === 'bad_data' ? TaintKindGroup::ALL_INPUT : [];
+        return [];
     }
 }