Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10047 #10048

Merged
merged 5 commits into from
Aug 5, 2023
Merged

Fix #10047 #10048

merged 5 commits into from
Aug 5, 2023

Conversation

cgocast
Copy link
Contributor

@cgocast cgocast commented Jul 25, 2023

We remove TaintedSql sink for PDOStatement related methods

stubs/extensions/pdo.phpstub Outdated Show resolved Hide resolved
stubs/extensions/pdo.phpstub Outdated Show resolved Hide resolved
@danog
Copy link
Collaborator

danog commented Jul 25, 2023

LGTM, @orklah you agree?

@danog
Copy link
Collaborator

danog commented Jul 25, 2023

Ah btw some tests would also be nice

@orklah
Copy link
Collaborator

orklah commented Jul 27, 2023

Thanks!

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Jul 27, 2023
@orklah orklah merged commit efcd443 into vimeo:master Aug 5, 2023
37 of 39 checks passed
@weirdan weirdan changed the title Fix #100047 Fix #10047 Aug 16, 2023
@weirdan weirdan linked an issue Aug 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TaintedSql false positives for prepared PDO statements
3 participants