-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade to vue 2.7 and remove @vue/composition-api #1307
base: v1
Are you sure you want to change the base?
Conversation
@jrohland thank you for this PR, I just tested it on my project and it appears to be working fine 👍 |
I'll test this over the weekend. Thanks. |
Hi @vinayakkulkarni, I'd also be quite interested to have this merged. Do you have an idea when you'll have time for this? Thanks! |
Hi @vinayakkulkarni! It would greatly help me if this were merged. When can we expect it? |
We really need this PR to be approved. Is there anything we can do to make it happen. Thanks! |
@vinayakkulkarni any status about this merge request? It will be valuable for those that who want to use the |
We've been using our own npm build off of the fork I made to introduce this change until if/when this PR is merged into the original repo. If it helps anyone else out it's available here: https://www.npmjs.com/package/@advisr/v-mapbox I didn't really want people pointing to our npm build in the case this PR got merged but it's been awhile since I opened this PR and I have a feeling Vue 2.7 support is no longer a priority for them. If you do want to use it you can just point the v-mapbox dependency in your package.json directly to this npm version like this: |
Vue 2.7 introduced the composition API as part of the base framework so that the @vue/composition-api dependency is no longer required. PR #1077 removed the dependency but didn't update the code to fix the references to the old dependency. This PR should complete the work in updating Vue as well as removing @vue/composition-api.