fix: Add tflint ignores (#32)

- Reduce tflint errors by adding ingores in fogg generated files - update golden test files
vincenthsh · Nov 18, 2022 · 8c9e885 · 8c9e885
1 parent e632e75
commit 8c9e885
Show file tree

Hide file tree

Showing 70 changed files with 455 additions and 13 deletions.
diff --git a/templates/templates/component/terraform/fogg.tf.tmpl b/templates/templates/component/terraform/fogg.tf.tmpl
@@ -71,23 +71,27 @@ terraform {
   {{ end}}
   }
 }
+# tflint-ignore: terraform_unused_declarations
 variable "env" {
   type    =  string
   default = "{{ .Env }}"
 }
 
+# tflint-ignore: terraform_unused_declarations
 variable "project" {
   type    =  string
   default = "{{ .Project }}"
 }
 
+# tflint-ignore: terraform_unused_declarations
 {{if .ProviderConfiguration.AWS}}
   variable "region" {
     type    =  string
     default = "{{ .ProviderConfiguration.AWS.Region }}"
   }
 {{ end }}
 
+# tflint-ignore: terraform_unused_declarations
 variable "component" {
   type =  string
   default = "{{ .Name }}"
@@ -107,11 +111,13 @@ variable "account" {
   }
 {{ end }}{{ end }}
 
+# tflint-ignore: terraform_unused_declarations
 variable "owner" {
   type =  string
   default = "{{ .Owner }}"
 }
 
+# tflint-ignore: terraform_unused_declarations
 variable "tags" {
   type =  object({project: string, env: string, service: string, owner: string, managedBy: string})
   default = {
@@ -132,6 +138,7 @@ variable "{{ $key }}" {
 
 {{ if .Global}}
 {{ if .Global.Backend.Kind}}
+# tflint-ignore: terraform_unused_declarations
 data "terraform_remote_state" "global" {
   backend = "{{ .Global.Backend.Kind }}"
 
@@ -143,6 +150,7 @@ data "terraform_remote_state" "global" {
 {{ $outer := . }}
 {{ range $component, $backend := .ComponentBackends  }}
 {{ if ne $component $outer.Name }}
+# tflint-ignore: terraform_unused_declarations
 data "terraform_remote_state" "{{ $component }}" {
   backend = "{{ $backend.Kind }}"
 
@@ -154,6 +162,7 @@ data "terraform_remote_state" "{{ $component }}" {
 {{ end }}
 
 {{ range $name, $backend := .AccountBackends }}
+# tflint-ignore: terraform_unused_declarations
 data "terraform_remote_state" "{{ $name }}" {
   backend = "{{ $backend.Kind }}"
 
@@ -163,6 +172,7 @@ data "terraform_remote_state" "{{ $name }}" {
 }
 {{ end }}
 
+# tflint-ignore: terraform_unused_declarations
 variable "aws_accounts" {
   type =  map(string)
   default = {

diff --git a/testdata/auth0_provider_yaml/Makefile b/testdata/auth0_provider_yaml/Makefile
diff --git a/testdata/auth0_provider_yaml/scripts/component.mk b/testdata/auth0_provider_yaml/scripts/component.mk
@@ -26,7 +26,7 @@ lint: lint-terraform-fmt lint-tflint ## run all linters for this component
 lint-tflint: ## run the tflint linter for this component
 	@printf "tflint: "
 ifeq ($(TFLINT_ENABLED),1)
-	@tflint || exit $$?;
+	@tflint -c $(REPO_ROOT)/.tflint.hcl || exit $$?;
 else
 	@echo "disabled"
 endif

diff --git a/testdata/auth0_provider_yaml/terraform/accounts/foo/fogg.tf b/testdata/auth0_provider_yaml/terraform/accounts/foo/fogg.tf
diff --git a/testdata/auth0_provider_yaml/terraform/envs/bar/bam/fogg.tf b/testdata/auth0_provider_yaml/terraform/envs/bar/bam/fogg.tf
diff --git a/testdata/auth0_provider_yaml/terraform/global/fogg.tf b/testdata/auth0_provider_yaml/terraform/global/fogg.tf
diff --git a/testdata/bless_provider_yaml/Makefile b/testdata/bless_provider_yaml/Makefile
diff --git a/testdata/bless_provider_yaml/scripts/component.mk b/testdata/bless_provider_yaml/scripts/component.mk
@@ -26,7 +26,7 @@ lint: lint-terraform-fmt lint-tflint ## run all linters for this component
 lint-tflint: ## run the tflint linter for this component
 	@printf "tflint: "
 ifeq ($(TFLINT_ENABLED),1)
-	@tflint || exit $$?;
+	@tflint -c $(REPO_ROOT)/.tflint.hcl || exit $$?;
 else
 	@echo "disabled"
 endif

diff --git a/testdata/bless_provider_yaml/terraform/accounts/foo/fogg.tf b/testdata/bless_provider_yaml/terraform/accounts/foo/fogg.tf
diff --git a/testdata/bless_provider_yaml/terraform/envs/bar/bam/fogg.tf b/testdata/bless_provider_yaml/terraform/envs/bar/bam/fogg.tf