fix: fix sign command options & show global options in subcommand help

[WhistlingZephyr]

Hello! It's me again. I was using this repo's CLI again and noticed that in v0.6.0's sign command was giving me this error:

And after realizing from the check of

amo-upload/src/bin.ts

Line 64 in 959bc26

verifyKeys(options, ['apiKey', 'apiSecret', 'addonId', 'addonVersion']);

my error only complained about every required option other than addonVersion which was explicitly defined inside the subcommand in

amo-upload/src/bin.ts

Lines 29 to 35 in 959bc26

	program
	.command('sign')
	.description(
	`Upload a new version for signing, check the status and download the signed file.
	This command could be run multiple times to check the status, and the version will not be uploaded repeatedly.`,
	)
	.option('--addon-version <addonVersion>', 'the version to create or query')

I found that for the sign command any of the global options weren't being passed at all. I noticed the list subcommand already has a solution for that in

amo-upload/src/bin.ts

Lines 96 to 102 in 959bc26

	.action(
	wrapError(async (_, command) => {
	const options = {
	...loadFromEnv(),
	...command.optsWithGlobals(),
	};
	verifyKeys(options, ['apiKey', 'apiSecret', 'addonId']);

so I copied it over to the sign command as well.

I also added the showGlobalOptions flag for commander.js mentioned in their readme and example that I found while looking up info on the initial error.

showGlobalOptions: show a section with the global options from the parent command(s)

I know v0.6.0 was pushed 10 months ago so I'm a bit late to the party, but would still appreciate having this CLI fix merged. Thanks!

[WhistlingZephyr]

Uhh, the CI is failing with

UsageError: This project is configured to use yarn because /home/runner/work/amo-upload/amo-upload/package.json has a "packageManager" field

I did notice the repo was mistakenly using yarn in .husky/pre-push:

amo-upload/.husky/pre-push

Line 4 in 959bc26

yarn ci

Not sure where else it's using that though (couldn't find a packageManager field in the package.json file), let me update that part and see if it fixes.

[WhistlingZephyr]

No luck, CI is still failing...

[WhistlingZephyr]

Could you try clearing caches from https://github.com/violentmonkey/amo-upload/actions/caches maybe? I think it could be pulling old cache where node_modules still used yarn. I can't find any more traces of yarn in the code.

[gera2ld]

Could you rebase to the lastest main branch? I've updated the github actions.

[WhistlingZephyr]

Done, CI works now.