Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Logs #16928

Closed
wants to merge 209 commits into from
Closed

Add Logs #16928

wants to merge 209 commits into from

Conversation

aadi-shopify
Copy link

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

harshit-gangal and others added 30 commits September 29, 2023 19:52
@harshit-gangal
Code freeze of release-18.0 (vitessio#14131)
90a9aa5 
Signed-off-by: Harshit Gangal <[email protected]>
@vitess-bot @GuptaManan100
[release-18.0] gen4: Support explicit column aliases on derived tables (
51d4b2c 
vitessio#14129) (vitessio#14156)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Manan Gupta <[email protected]>
@vitess-bot
[release-18.0] docker: add dedicated vtorc container (vitessio#14126) (…
ade16e3 
…vitessio#14148)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@harshit-gangal @frouioui
Release of v18.0.0-rc1 (vitessio#14136)
6ab165a 
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
@harshit-gangal
Back to dev mode after v18.0.0-rc1 release (vitessio#14169)
8bb426b 
Signed-off-by: Harshit Gangal <[email protected]>
@vitess-bot
[release-18.0] Migrate CreateLookupVindex and ExternalizeVindex to vt…
09cd7b2 
…ctldclient (vitessio#14086) (vitessio#14183)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@github-actions @frouioui
[release-18.0] Upgrade the Golang version to go1.21.2 (vitessio#14195)
0f9fd92 
Co-authored-by: frouioui <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
@rohit-nayak-ps
[Release 18.0] Backport of #17174 (vitessio#14210)
2b28e01 
Signed-off-by: Rohit Nayak <[email protected]>
@mattlord
[release-18.0] Migrate Materialize command to vtctldclient (vitessio#…
f4a85fb 
…14184) (vitessio#14214)

Signed-off-by: Matt Lord <[email protected]>
@shlomi-noach
[Release 18.0]: Online DDL: timeouts for all gRPC calls (vitessio#14182…
d63cea3 
…) (vitessio#14189)

Signed-off-by: Shlomi Noach <[email protected]>
@vitess-bot
[release-18.0] Optimize the GetWorkflows RPC (vitessio#14212) (vitess…
fec93ca 
…io#14233)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@github-actions @frouioui
[release-18.0] Upgrade the Golang version to go1.21.3 (vitessio#14230)
ac483b2 
Co-authored-by: frouioui <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
@vitess-bot
[release-18.0] VReplication: Add missing info to vtctldclient workflo…
16e8208 
…w SHOW output (vitessio#14225) (vitessio#14240)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot @mattlord
[release-18.0] Move all examples to vtctldclient (vitessio#14226) (vi…
22f7509 
…tessio#14241)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Matt Lord <[email protected]>
@vitess-bot
[release-18.0] Throttler: set timeouts on gRPC communication and on t…
d62e890 
…opo communication (vitessio#14165) (vitessio#14167)

Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-18.0] Fix anonymous paths in cobra code-gen (vitessio#14185) (…
c074978 
…vitessio#14238)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-18.0] fix: insert with negative value (vitessio#14244) (vite…
25d7ba4 
…ssio#14247)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@shlomi-noach
[release-18.0] Tablet throttler: fix race condition by removing gorou…
dcc8a0a 
…tine call (vitessio#14179) (vitessio#14198)
@vitess-bot @dependabot
[release-18.0] Bump github.com/cyphar/filepath-securejoin from 0.2.3 …
3612ec5 
…to 0.2.4 (vitessio#14239) (vitessio#14253)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vitess-bot @dependabot
[release-18.0] Bump postcss from 8.4.21 to 8.4.31 in /web/vtadmin (vi…
dd6f4d0 
…tessio#14173) (vitessio#14258)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mattlord
Add vtctldclient info to the 18.0 summary (vitessio#14259)
12897b5 
Signed-off-by: Matt Lord <[email protected]>
@vitess-bot @dependabot
[release-18.0] Bump golang.org/x/net from 0.14.0 to 0.17.0 (vitessio#…
9f240c7 
…14260) (vitessio#14264)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vitess-bot
[release-18.0] Bypass cobra completion commands so they still function (
fe31219 
vitessio#14217) (vitessio#14234)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-18.0] fix: analyze statement parsing and planning (vitessio#…
3df4788 
…14268) (vitessio#14275)

Signed-off-by: Harshit Gangal <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot
[release-18.0] VReplication: Add traffic state to vtctldclient workfl…
8de04b5 
…ow status output (vitessio#14280) (vitessio#14282)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot @mattlord
[release-18.0] Make vtctldclient mount command more standard (vitessi…
5cf1bd8 
…o#14281) (vitessio#14283)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Matt Lord <[email protected]>
@vitess-bot
[release-18.0] VReplication: error on vtctldclient commands w/o table…
fe27a3f 
…t types (vitessio#14294) (vitessio#14298)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
@vitess-bot @GuptaManan100
[release-18.0] Rename Foreign Key enum values in VSchema and drop `FK…
e0f96d3 
…_` prefix (vitessio#14274) (vitessio#14299)

Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
@vitess-bot @dependabot
[release-18.0] Bump @babel/traverse from 7.21.4 to 7.23.2 in /web/vta…
d8a5dc0 
…dmin (vitessio#14304) (vitessio#14308)

Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@vitess-bot @deepthi @GuptaManan100
[release-18.0] release notes: edit summary for consistency (vitessio#…
5f0df9a 
…14319) (vitessio#14320)

Co-authored-by: Deepthi Sigireddi <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
shivnagarajan and others added 22 commits May 10, 2024 13:54
@shivnagarajan
fix vreplication_test
c3f3417
@shivnagarajan
Merge pull request #164 from Shopify/fix_tests_for_v18
aa73e7f 
fix tests for CI
@shivnagarajan
Merge pull request #162 from Shopify/v18.0.5-shopify-1-candidate
f10e224 
V18.0.5 shopify 1 candidate
@vitess-bot @mattlord @brendar
Backport: [release-18.0] CI: Fix for xtrabackup install failures (vit…
647a5af 
…essio#16329) (vitessio#16331)

Signed-off-by: Matt Lord <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Matt Lord <[email protected]>
Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Merge pull request #172 from Shopify/v18.0.5-shopify-2-candidate-fix-…
72be81a 
…percona-xtrabackup-dep

Backport: [release-18.0] CI: Fix for xtrabackup install failures (vitessio#16329) (vitessio#16331)
@brendar
Backport: VTCombo: Ensure VSchema exists when creating keyspace (vite…
e1988c0 
…ssio#16094)

Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Merge pull request #171 from Shopify/v18.0.5-shopify-2-candidate
a1eceeb 
Backport: VTCombo: Ensure VSchema exists when creating keyspace (vitessio#16094)
@vitess-bot @brendar
Backport: [release-18.0] Fix the install dependencies script in Docker (
9c0065f 
vitessio#16340) (vitessio#16345)

Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Merge pull request #177 from Shopify/v18.0.5-shopify-2-candidate-fix-…
41f5892 
…lite-image-build

Backport: [release-18.0] Fix the install dependencies script in Docker (vitessio#16340) (vitessio#16345)
@brendar
Release commit for 18.0.5-shopify-3
fe8cb8a 
Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Merge pull request #178 from Shopify/v18.0.5-shopify-3-create_release-1
06dc7eb 
Release commit for 18.0.5-shopify-3
@brendar
vtcombo: close query service on drop database (vitessio#16606)
75411b0 
Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Fix assertion to allow negative connection delta. v18 appears to crea…
9fcf533 
…te a lot of connections eagerly.

Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Release commit for 18.0.5-shopify-4
5a66877 
Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Merge pull request #184 from Shopify/v18.0.5-shopify-4-backport-vtcom…
ede4ad1 
…bo-conn-leak

Backport v18: vtcombo: close query service on drop database
@brendar
Merge pull request #185 from Shopify/v18.0.5-shopify-4-create_release-1
817239d 
Release commit for 18.0.5-shopify-4
@davidpiegza @brendar
Backport: Gracefully shutdown VTGate instances (vitessio#14219)
b4735df 
Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Merge pull request #187 from Shopify/backport-graceful-vtgate-shutdow…
8ba1756 
…n-to-v18

Backport: Gracefully shutdown VTGate instances
@brendar
Release commit for 18.0.5-shopify-5
0da1082 
Signed-off-by: Brendan Dougherty <[email protected]>
@brendar
Merge pull request #188 from Shopify/v18.0.5-shopify-5-candidate-crea…
c2d61ca 
…te_release-1

Release commit for 18.0.5-shopify-5
@brendar
Merge pull request #189 from Shopify/v18.0.5-shopify-5-candidate
ff8fdc5 
Release v18.0.5-shopify-5
@aadi-shopify
Add logs to .Get methods
b6e9789
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 10, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 10, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 10, 2024
@aadi-shopify aadi-shopify deleted the v18.0.5-shopify-5-aadi branch October 10, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi Awaiting requested review from deepthi deepthi will be requested when the pull request is marked ready for review deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 will be requested when the pull request is marked ready for review ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit will be requested when the pull request is marked ready for review notfelineit is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 will be requested when the pull request is marked ready for review GuptaManan100 is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach will be requested when the pull request is marked ready for review shlomi-noach is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins will be requested when the pull request is marked ready for review derekperkins is a code owner

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt will be requested when the pull request is marked ready for review timvaillancourt is a code owner

@arthurschreiber arthurschreiber Awaiting requested review from arthurschreiber arthurschreiber will be requested when the pull request is marked ready for review arthurschreiber is a code owner

@vmg vmg Awaiting requested review from vmg vmg will be requested when the pull request is marked ready for review vmg is a code owner

Assignees
No one assigned
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.