Improved Compatibility Around LAST_INSERT_ID - evalengine

[systay]

Description

This PR improves last_insert_id(x) behavior to align more closely with MySQL in various scenarios.

Here we are adding capability for the evalengine to handle last_insert_id(x) queries in vtgate. This enables running dual only queries without having to send it down to mysql, such as:

select last_insert_id(123);

It also enables handling situations where the value is calculated in the vtgate and not something MySQL sends to us, like aggregation across shards:

select last_insert_id(count(*)) from user where foo = 'bar'

This PR contains commits from #17408

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[harshit-gangal]

This PR should handle all the insert cases for last_insert_id

[codecov]

Codecov Report

Attention: Patch coverage is 77.57009% with 72 lines in your changes missing coverage. Please review.

Project coverage is 67.63%. Comparing base (9714713) to head (42d8530).

Files with missing lines	Patch %	Lines
go/vt/vttablet/tabletserver/query_executor.go	49.39%	42 Missing ⚠️
go/vt/vtgate/executorcontext/vcursor_impl.go	53.57%	13 Missing ⚠️
go/vt/vtgate/engine/plan_description.go	0.00%	4 Missing ⚠️
go/vt/vtgate/evalengine/fn_misc.go	80.00%	4 Missing ⚠️
go/vt/vtgate/engine/insert.go	60.00%	2 Missing ⚠️
go/vt/vtgate/evalengine/translate_builtin.go	60.00%	2 Missing ⚠️
go/vt/vtgate/scatter_conn.go	83.33%	2 Missing ⚠️
go/vt/vtgate/engine/lock.go	0.00%	1 Missing ⚠️
go/vt/vtgate/engine/unlock.go	0.00%	1 Missing ⚠️
go/vt/vtgate/engine/vexplain.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17409      +/-   ##
==========================================
- Coverage   67.63%   67.63%   -0.01%     
==========================================
  Files        1581     1581              
  Lines      253860   254042     +182     
==========================================
+ Hits       171708   171811     +103     
- Misses      82152    82231      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vmg]

It truly is a feat of modern engineering.