Fix week number for date_format evalengine function #17432
Merged
+25
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Type: Bug
Component: Evalengine
GuptaManan100
requested review from
harshit-gangal,
systay,
frouioui and
mattlord
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
GuptaManan100
commented
Dec 26, 2024
Comment on lines
376
to
+377
| func (fmtWeek1) format(dst []byte, t DateTime, prec uint8) []byte { | ||
| year, week := t.Date.ISOWeek() | ||
| if year < t.Date.Year() { | ||
| week = 0 | ||
| } | ||
| week := t.Date.Week(1) |
There was a problem hiding this comment.
I can make the same change for the other fmtWeek functions. Haven't done that yet, but i think it makes sense to just use the same implementation for everything.
There was a problem hiding this comment.
@GuptaManan100 i think we should do that indeed. Makes it less error prone and the week function afaik is already better tested too.
There was a problem hiding this comment.
@GuptaManan100 Pushed up the fix to always used the documented mode number.
|
I'm not sure about the backports either. Do we need to backport this fix to older releases? |
GuptaManan100
removed
NeedsDescriptionUpdate
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17432 +/- ##
==========================================
- Coverage 67.68% 67.66% -0.02%
==========================================
Files 1583 1583
Lines 254321 254363 +42
==========================================
- Hits 172131 172122 -9
- Misses 82190 82241 +51 ☔ View full report in Codecov by Sentry. |
harshit-gangal
approved these changes
Dec 26, 2024
To ensure we avoid additional bugs, always use the mode documented instead if re-implementing something similar here. Signed-off-by: Dirkjan Bussink <[email protected]>
Don't have a super strong opinion, we could back port to v21 only as a small bugfix? |
dbussink
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the way evalengine finds the week for the date_format function. It was noticed that the
Week()function works fine, but we weren't using it. This PR changes that to fix the issue ran into in #17431.Related Issue(s)
Checklist
Deployment Notes