Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Merge: Cobradocs sync: improve makefile, resync without commit hash #1904

Draft
wants to merge 6 commits into
base: prod
Choose a base branch
from

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Dec 14, 2024

Description

Updates the Makefile for cobra doc generation related targets:

  • Create a single target for all binaries
  • Add new files automatically to the repo with the Vitess repo hash as part of the commit message
  • Also improved error logging

Todos

Copy link

netlify bot commented Dec 14, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit eb43dfe
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/675ee83286c97b0008b2c89b
😎 Deploy Preview https://deploy-preview-1904--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps rohit-nayak-ps changed the title Cobradocs sync: improve makefile, resync without commit hash WIP: Cobradocs sync: improve makefile, resync without commit hash Dec 15, 2024
…s empty commit for each binary

Signed-off-by: Rohit Nayak <[email protected]>
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review December 17, 2024 15:22
@rohit-nayak-ps rohit-nayak-ps changed the title WIP: Cobradocs sync: improve makefile, resync without commit hash Do Not Merge: Cobradocs sync: improve makefile, resync without commit hash Dec 17, 2024
@rohit-nayak-ps rohit-nayak-ps marked this pull request as draft December 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant