Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data key to breakdown documents if missing #236

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

thalassemia
Copy link
Contributor

When retrieving data from MongoDB, the assemble_data function expects each document to have a data key. When a document is too large, the breakdown_data method splits the large nested dictionary into smaller sub-dictionaries, some of which may not have a data key after the split. This PR ensures that all documents have a data key, not just those that also have a corresponding time key. This fixes an issue where a very large configuration document (no time key) is broken down into sub-dictionaries, one of which lacks the data key and breaks assemble_data.


By creating this pull request, I agree to the Contributor License
Agreement, which is available in CLA.md at the top level of this
repository.

@thalassemia thalassemia requested a review from a team as a code owner January 29, 2024 20:28
Copy link
Member

@eagmon eagmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find @thalassemia!

@eagmon
Copy link
Member

eagmon commented Feb 1, 2024

@thalassemia do you need a new release?

@thalassemia
Copy link
Contributor Author

Yeah a new release would be great! As an aside, I want to try creating GitHub Actions tests for the MongoDB functionality. I'll do some testing and hopefully have a PR up in the next week or so.

@eagmon
Copy link
Member

eagmon commented Feb 1, 2024

Great idea to test mongoDB functionality. I'll merge and release this now, v1.6.2

@eagmon eagmon merged commit 58f7a84 into master Feb 1, 2024
12 checks passed
@eagmon eagmon deleted the emit_config branch February 21, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants