Add tests for MongoDB and fix bugs #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalassemia
commented
Feb 2, 2024
| @@ -71,7 +71,7 @@ def test_hierarchy_update() -> None: | |||
| 'Protein': {'X': 50 * units.mg / units.mL}}}} | |||
|
|
|||
| # make a txtl composite, embedded under an 'agents' store | |||
| txtl_composer = AgentDivision({}) | |||
| txtl_composer = AgentDivision({'growth': {'default_growth_noise': 0}}) | |||
There was a problem hiding this comment.
This test randomly failed on me once, so I'm hoping this change makes it more reproducible.
eagmon
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
looks great @thalassemia!
Just a question about the pytest workflow -- how does this mongo image work? Does github host this?
|
The image is hosted on Docker Hub: https://hub.docker.com/_/mongo. In this PR, I pinned the 6.0.13 version of the image for no particular reason. We could set the tag to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding MongoDB to the test environment proved very straightforward thanks to service containers. I repurposed an existing script to test large emits, query capabilities, and manual insertion of documents. Along the way, I fixed three issues:
timekey was not being added to broken-down emits whentimewas 0delete_experiment_from_databasefailed when using multiple CPU processesdata_to_databasewere not retrievable bydata_from_databaseunless a specific structure was adhered toAccording to
pytest, coverage ofemitter.pywent from 44% to 90% with this PR. Most of the remaining untested code is in the MongoDB Atlas functions.By creating this pull request, I agree to the Contributor License
Agreement, which is available in
CLA.mdat the top level of thisrepository.