Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds mapping helpers to spawn records cabinets, records cabinets dont spawn documents about impossible to get abnormalities #2129

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Gboster-0
Copy link
Collaborator

About The Pull Request

This PR does the following:

  • Adds mapping helpers that automatically place closets about relevant abnormality documents, stored as a var/list inside of the closets
  • The records guide is no longer a ZAYIN document (now all documents except tools are checked for abnormality origin, and if it fails admins are informed)

Why It's Good For The Game

Looking at 300 documents instead of 750 is quite a bit nicer to the player and encurages records more

image

Changelog

🆑
add: Records cabinets now no longer have documents about abnormalities that are impossible to get in the abnormality queue via gamemodes
code: Added records filing cabinets mapping helpers
/:cl:

@Kitsunemitsu Kitsunemitsu added the Tweak A small change/addition to already existing systems. label May 10, 2024
@Gboster-0
Copy link
Collaborator Author

no touchy the test-merge button before #2130 is merged

@Gboster-0 Gboster-0 requested a review from EgorDinamit as a code owner June 12, 2024 17:52
@Kitsunemitsu
Copy link
Contributor

Can you give this a quick update?

@Gboster-0
Copy link
Collaborator Author

No i didnt, wut

@Gboster-0 Gboster-0 reopened this Aug 6, 2024
@Gboster-0 Gboster-0 marked this pull request as draft October 15, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak A small change/addition to already existing systems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants