Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abnormality Helper File[WIP] #2364

Merged

Conversation

InsightfulParasite
Copy link
Collaborator

About The Pull Request

Puts some common procs in a helper file.
Naked Nest's armor to abnormality defense conversion is moved to _helper Big wolf and Steels clearsky proc moved to helper. Drophardclothing moved to _helper

Why It's Good For The Game

Possibly can simplify some commonly used code.

Changelog

🆑
tweak: steel
tweak big_wolf
tweak: naked_nest
/:cl:

@InsightfulParasite InsightfulParasite added the Code improvement Code is now easier to copy paste. label Aug 6, 2024
@InsightfulParasite InsightfulParasite force-pushed the abnormality-proc-pushback branch from fbf05b3 to e03a3b4 Compare August 6, 2024 19:54
@InsightfulParasite InsightfulParasite changed the title Abnormality Helper File Abnormality Helper File[WIP] Aug 7, 2024
@InsightfulParasite InsightfulParasite marked this pull request as ready for review August 22, 2024 23:24
Puts some common procs in a helper file.
Naked Nest's armor to abnormality defense conversion is moved to _helper
Big wolf and Steels clearsky proc moved to helper.
Drophardclothing moved to _helper

tweak: steel
tweak big_wolf
tweak: naked_nest
Copy link
Contributor

@Kitsunemitsu Kitsunemitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Looks good to me, cleans up a lot of our shitty code

@Kitsunemitsu Kitsunemitsu merged commit 5668d1f into vlggms:master Oct 1, 2024
8 checks passed
@InsightfulParasite InsightfulParasite deleted the abnormality-proc-pushback branch October 14, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvement Code is now easier to copy paste.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants