Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Community E.G.O. #2456

Merged
merged 1 commit into from
Oct 20, 2024
Merged

New Community E.G.O. #2456

merged 1 commit into from
Oct 20, 2024

Conversation

Coxswain-Navigator
Copy link
Contributor

@Coxswain-Navigator Coxswain-Navigator commented Oct 1, 2024 •
edited
Loading

About The Pull Request

Adds some new E.G.O. for upcoming community abnormalities.

  • I noticed that book_burn and effect_burn are the same sound effect, so I condensed them into one.

Why It's Good For The Game

Cool toys for the well I guess, saves me from making them later.

Changelog

🆑
add: Added new E.G.O.
/:cl:

@Coxswain-Navigator Coxswain-Navigator added the Expansion Expands upon a feature label Oct 1, 2024
@Coxswain-Navigator Coxswain-Navigator marked this pull request as draft October 1, 2024 19:39
@Coxswain-Navigator Coxswain-Navigator force-pushed the buncha-new-ego branch 5 times, most recently from 6de9a74 to 89e5b82 Compare October 6, 2024 17:40
@Coxswain-Navigator Coxswain-Navigator force-pushed the buncha-new-ego branch 3 times, most recently from 405f661 to 0653df8 Compare October 11, 2024 23:46
@Coxswain-Navigator Coxswain-Navigator force-pushed the buncha-new-ego branch 2 times, most recently from 66ff021 to 7c7f70f Compare October 20, 2024 04:25
@Coxswain-Navigator Coxswain-Navigator marked this pull request as ready for review October 20, 2024 04:25
@Coxswain-Navigator Coxswain-Navigator force-pushed the buncha-new-ego branch 2 times, most recently from 0b24e23 to 34919c7 Compare October 20, 2024 04:54
@Coxswain-Navigator
New Community E.G.O.
8e8ba90 
armor

adds some sprites

rank bumps some ego

adds some stuff

finished 2/5 weapon code

gonna commit this real quick

code update

finishes the last two ego

adds sprites

should fix linters

removes unused code

attribute fix
@Gboster-0 Gboster-0 added the Code improvement Code is now easier to copy paste. label Oct 20, 2024
Gboster-0
Gboster-0 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@Gboster-0 Gboster-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything locally, seems to be smooth enough for a merge.
For the future /obj/item/ego_weapon/lance/miasma has a defined in-hand sprite but the sprite does not exist though.

@Gboster-0 Gboster-0 merged commit 188a354 into vlggms:master Oct 20, 2024
9 checks passed
@Coxswain-Navigator Coxswain-Navigator deleted the buncha-new-ego branch October 20, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gboster-0 Gboster-0 Gboster-0 approved these changes

Assignees
No one assigned
Labels
Code improvement Code is now easier to copy paste. Expansion Expands upon a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coxswain-Navigator @Gboster-0