-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Column Families to SplinterDB #586
Open
etwest
wants to merge
13
commits into
main
Choose a base branch
from
column_family
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for splinterdb canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a foundational attempt to add support for column families in SplinterDB.
This is accomplished with the
splinterdb_column_family
struct that wrapssplinterdb
. Each column family has an associated struct and operations upon the family are performed by passing the struct to insert/delete/update/etc functions.When operations upon keys are performed by a column family the user key is prepended with a 4 byte column family id. These keys are then commingled in a single splinterdb instance (though all key/value pairs for a single column family are stored contiguously in the key space).
The API for column families is defined in the
splinterdb/column_family.h
header.Limitations/To-Do:
Maximum key size of 512 bytes for column families.Column family iterators are a bit awkward. Currently the user needs to allocate the iterator such that it is relatively long lived. User is managing memory. It would be better to make a contiguous strict (I.e. direct splinter iterator rather than pointer) and perform all the allocation in one shot in the init function.