Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ODS runbook invocation resource #1020

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ksamoray
Copy link
Collaborator

No description provided.

@ksamoray
Copy link
Collaborator Author

ksamoray commented Nov 1, 2023

/test-all

@ksamoray
Copy link
Collaborator Author

ksamoray commented Nov 2, 2023

/test-all

1 similar comment
@ksamoray
Copy link
Collaborator Author

ksamoray commented Nov 2, 2023

/test-all

@ksamoray ksamoray force-pushed the ods-runbook-invocation branch 3 times, most recently from 4c403fb to c471bc0 Compare November 6, 2023 10:00
@ksamoray ksamoray force-pushed the ods-runbook-invocation branch 4 times, most recently from dc73bfb to a73f745 Compare November 16, 2023 13:27
Schema: map[string]*schema.Schema{
"nsx_id": getNsxIDSchema(),
"path": getPathSchema(),
// Due to a bug, invocations with a display_name specification fail, and when there's none set, NSX assigns
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the user can't specify display_name?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, he can't. The runbook won't execute, it's a bug which they intend to fix obviously.

},
},
},
"runbook_path": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPolicyPathSchema?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this and below be defined as ForceNew?

return nil
}

func resourceNsxtPolicyODSRunbookInvocationUpdate(d *schema.ResourceData, m interface{}) error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user changes description, this will result in constant non-empty diff. Do tags/description have any value for this resource, perhaps we can remove them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, if anyone ever needs them we can reevaluate how to handle these.

@ksamoray
Copy link
Collaborator Author

/test-all

@ksamoray ksamoray force-pushed the ods-runbook-invocation branch 2 times, most recently from 1f7f731 to f79fcee Compare November 29, 2023 09:26
@ksamoray
Copy link
Collaborator Author

/test-all

@ksamoray ksamoray force-pushed the ods-runbook-invocation branch 2 times, most recently from 3c78198 to 2e834f5 Compare December 3, 2023 11:19
@ksamoray
Copy link
Collaborator Author

ksamoray commented Dec 9, 2023

/test-all

1 similar comment
@ksamoray
Copy link
Collaborator Author

/test-all

@ksamoray
Copy link
Collaborator Author

/test-all

@ksamoray
Copy link
Collaborator Author

/test-all

Implement nsxt_policy_ods_pre_defined_runbook for ODS runbook framework.

Signed-off-by: Kobi Samoray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants