Display current time on same row as navigation buttons on narrow screens #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, on narrow displays, it should appear on the same row as the buttons and not overlap the stream name/title anymore. Also use the `navbar-text` class on the text for positioning.
This fixes the positioning of the buttons now that the time display is inside the wrapper, and maybe makes a little more sense, too, since this is not a form.
|
Great, thanks for merging! Since this should also resolve #141, you might consider closing that, too. (Altough the streaming-website/configs/conferences/rc3/main.less Lines 95 to 97 in 5ab7583 body element so the room name would still be hidden - but divoc_r2r is over and archived anyway ;).)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the markup for the current time display inside the same element as the navigation buttons, which prevents it from being moved to a separate row on narrow displays, which in turn resulted in 'hidden' page elements as was noted in e.g. #141 (for DiVOC R2R) and IRC (for rC3 2021).