-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and run linting #690
Merged
Merged
Fix and run linting #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove dict type hinting that I think was not valid anyways - use isinstance instead of type == numpy.ndarray - fix an incorrect variable name in an error message
- Use isinstance checks instead of type == - Add missing values in error message (printed with f-strings to help user find root of issue)
…ng values in fstring for error message
…whitespace before colon
…, remove unused f-string
…lter in loss/umap.py
…me_classification_model.py
…tance/functional.py
…riables in learncurve/curvefit.py
… triggering invalid escape sequence warning from flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds linting dependencies (isort, black, flake8) and a linting session to the noxfile that runs those.
I also ran them all to make an initial pass at cleaning up. Will still need to fix one or two stray warnings.