Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix close on outside click #295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aclarembeau
Copy link

Goal of this pull request is to fix a buggy behavior with the feature "close on outside click".
It happens that, by using on "click" instead on "mousedown", we can close the window by starting a click inside the modal, but, releasing it outside of it.

I found this not to be ideal, as, this is not wanted in most of the scenarios.
So, that's why I've created this PR.

@aclarembeau aclarembeau closed this Apr 1, 2019
@aclarembeau aclarembeau reopened this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants