Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added first version of Steam #222

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added first version of Steam #222

wants to merge 2 commits into from

Conversation

4n4n4s
Copy link
Contributor

@4n4n4s 4n4n4s commented Sep 22, 2023

added some improvements over #201

Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@vogler
Copy link
Owner

vogler commented Dec 21, 2023

Thanks!
So by default this only claims the games in steam-games.json? Not sure I understand the idea here.
Is there a problem with using https://www.gamerpower.com/api/giveaways?platform=steam&type=game by default?

@4n4n4s
Copy link
Contributor Author

4n4n4s commented Dec 29, 2023

Thanks! So by default this only claims the games in steam-games.json? Not sure I understand the idea here. Is there a problem with using https://www.gamerpower.com/api/giveaways?platform=steam&type=game by default?

It should be able to claim both.
The json way could be optional as it was just my first implementation when I didn't make use of the gamerpower api yet and instead was using people posting on x (twitter) as info. Meaning we can also drop this and just use gamerpower.

@KairuByte
Copy link

KairuByte commented Jan 3, 2024

Just tested this out.

First issue I ran into is that this appears to assume it's being run within .\src which goes against all other modules. Editing the .\config.js and .\util.js pointers to point to the proper folder instead of root allows the module to run.

Next issue is that it is looking for a:has-text("Sign In") which is incorrect, it should actually be looking for a:has-text("login").

The final notification also doesn't seem to mention there are games which can be claimed outside of steam. This might be a good optional value, since some people will want fully automated solutions, and some may want a convenient way to tap into the places they need to, in order to get the games manually.

Finally, SHOW=0 is not honored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants