ue: fix undefined price #44 #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix the issue with undefined price. The price wouldn't be defined in the shopping cart unless clicked if it was empty on page load.
|
Thanks! |
Primajin
reviewed
Jul 17, 2024
| await page.waitForTimeout(2000); | ||
| const price = (await page.locator('.shopping-cart .total .price').innerText()).split(' '); | ||
| console.log('Price: ', price[1], 'instead of', price[0]); | ||
| if (price[1] != '0') { | ||
| if (price[1] != '0' && price[1] != '$0.00') { | ||
| const err = 'Price is not 0! Exit! Please <a href="https://github.com/vogler/free-games-claimer/issues/44">report</a>.'; |
There was a problem hiding this comment.
I wonder if we should maybe print the price here, just so that people see what it is instead and thus can report better issues in the future?
Suggested change
| const err = 'Price is not 0! Exit! Please <a href="https://github.com/vogler/free-games-claimer/issues/44">report</a>.'; | |
| const err = `Price is ${price[1]} and thus not 0! Exit! Please <a href="https://github.com/vogler/free-games-claimer/issues/44">report</a>.`; |
Primajin
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the issue with undefined price mentioned in #44 .
The price wouldn't be defined in the shopping cart unless clicked if it was empty on page load.