Skip to content

Commit

Permalink
Merge pull request #928 from giswqs/master
Browse files Browse the repository at this point in the history
Fixed typos
  • Loading branch information
jtpio authored Aug 26, 2021
2 parents f29567b + 0654c5d commit 9d89e82
Show file tree
Hide file tree
Showing 16 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
VOILA_TEST_DEBUG=1 VOILA_TEST_XEUS_CLING=1 py.test tests/ --async-test-timeout=240
VOILA_TEST_DEBUG=1 VOILA_TEST_XEUS_CLING=1 py.test tests/ --async-test-timeout=240
voila --help # Making sure we can run `voila --help`
# tests if voila sends a 'heartbeat' to avoid proxies from closing an appearently stale connection
# tests if voila sends a 'heartbeat' to avoid proxies from closing an apparently stale connection
# Note that wget is the only easily available software that has a read-timeout
voila tests/notebooks/sleep10seconds.ipynb --port=8878 --VoilaConfiguration.http_keep_alive_timeout=2 &
sleep 2
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@
- Add flag for nbextensions [#185](https://github.com/voila-dashboards/voila/pull/185) ([@SylvainCorlay](https://github.com/SylvainCorlay))
- Expose phosphor [#183](https://github.com/voila-dashboards/voila/pull/183) ([@SylvainCorlay](https://github.com/SylvainCorlay))
- add top-level serverextension and installation instructions [#182](https://github.com/voila-dashboards/voila/pull/182) ([@ivanov](https://github.com/ivanov))
- Add @web.autenticated to /voila/tree [#181](https://github.com/voila-dashboards/voila/pull/181) ([@jtpio](https://github.com/jtpio))
- Add @web.authenticated to /voila/tree [#181](https://github.com/voila-dashboards/voila/pull/181) ([@jtpio](https://github.com/jtpio))
- Review example notebooks [#178](https://github.com/voila-dashboards/voila/pull/178) ([@SylvainCorlay](https://github.com/SylvainCorlay))
- Update environment.yml [#177](https://github.com/voila-dashboards/voila/pull/177) ([@lheagy](https://github.com/lheagy))
- Fixup nbextension [#176](https://github.com/voila-dashboards/voila/pull/176) ([@SylvainCorlay](https://github.com/SylvainCorlay))
Expand Down
2 changes: 1 addition & 1 deletion docs/source/deploy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -398,4 +398,4 @@ Sharing Voilà applications

4. Send the link

5. When using the ngrok link, the requests will be forwared to your local instance of Voilà.
5. When using the ngrok link, the requests will be forwarded to your local instance of Voilà.
2 changes: 1 addition & 1 deletion packages/voila/src/loader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function moduleNameToCDNUrl(moduleName: string, moduleVersion: string) {
* @param version The semver range for the module, if loaded from a CDN.
*
* By default, the CDN service used is cdn.jsdelivr.net. However, this default can be
* overriden by specifying another URL via the HTML attribute
* overridden by specifying another URL via the HTML attribute
* "data-jupyter-widgets-cdn" on a script tag of the page.
*
* The semver range is only used with the CDN.
Expand Down
4 changes: 2 additions & 2 deletions packages/voila/src/manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ export class WidgetManager extends JupyterLabManager {
} catch (error) {
// Each widget view tag rendering is wrapped with a try-catch statement.
//
// This fixes issues with widget models that are explicitely "closed"
// This fixes issues with widget models that are explicitly "closed"
// but are still referred to in a previous cell output.
// Without the try-catch statement, this error interupts the loop and
// Without the try-catch statement, this error interrupts the loop and
// prevents the rendering of further cells.
//
// This workaround may not be necessary anymore with templates that make use
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ all of MD as it is not optimized for dense, information rich UIs.
/* @import url('https://fonts.googleapis.com/css?family=Roboto+Mono'); */

/*
* Added for compabitility with output area
* Added for compatibility with output area
*/
:root {
--jp-icon-search: none;
Expand Down
2 changes: 1 addition & 1 deletion tests/app/nbextensions_test.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# tests programmatic config of template sytem
# tests programmatic config of template system
import pytest

import os
Expand Down
2 changes: 1 addition & 1 deletion tests/app/template_cli_test.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# tests programmatic config of template sytem
# tests programmatic config of template system
import pytest

import os
Expand Down
2 changes: 1 addition & 1 deletion tests/app/template_config_file_test.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# tests config of template sytem from JSON file
# tests config of template system from JSON file
import pytest

import os
Expand Down
2 changes: 1 addition & 1 deletion tests/app/template_custom_test.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# tests programmatic config of template sytem
# tests programmatic config of template system
import pytest

import os
Expand Down
2 changes: 1 addition & 1 deletion tests/execute_output_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@


# based on nbconvert.preprocessors.tests.test_execute.TestExecute
# we cannot import it because pytest would then also execute thoses tests
# we cannot import it because pytest would then also execute those tests
def normalize_output(output):
"""
Normalizes outputs for comparison.
Expand Down
2 changes: 1 addition & 1 deletion tests/server/nbextensions_test.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# tests programmatic config of template sytem
# tests programmatic config of template system
import pytest

import os
Expand Down
4 changes: 2 additions & 2 deletions voila/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class Voila(Application):
connection_dir_root = Unicode(
config=True,
help=_(
'Location of temporry connection files. Defaults '
'Location of temporary connection files. Defaults '
'to system `tempfile.gettempdir()` value.'
)
)
Expand Down Expand Up @@ -323,7 +323,7 @@ def _init_asyncio_patch(self):
asyncio implementation on Windows
Pick the older SelectorEventLoopPolicy on Windows
if the known-incompatible default policy is in use.
do this as early as possible to make it a low priority and overrideable
do this as early as possible to make it a low priority and overridable
ref: https://github.com/tornadoweb/tornado/issues/2608
FIXME: if/when tornado supports the defaults in asyncio,
remove and bump tornado requirement for py38
Expand Down
2 changes: 1 addition & 1 deletion voila/handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ async def get(self, path=None):
# render notebook in snippets, and flush them out to the browser can render progresssively
async for html_snippet, resources in self.exporter.generate_from_notebook_node(notebook, resources=resources, extra_context=extra_context):
self.write(html_snippet)
self.flush() # we may not want to consider not flusing after each snippet, but add an explicit flush function to the jinja context
self.flush() # we may not want to consider not flushing after each snippet, but add an explicit flush function to the jinja context
# yield # give control back to tornado's IO loop, so it can handle static files or other requests
self.flush()

Expand Down
2 changes: 1 addition & 1 deletion voila/paths.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def collect_paths(
# first find a list of the template 'hierarchy'
template_names = _find_template_hierarchy(app_names, template_name, root_dirs)

# the order of the loop determintes the precedense of the template system
# the order of the loop determines the precedense of the template system
# * first template_names, e.g. if we inherit from default template, we only
# want to find those files last
for template_name in template_names:
Expand Down
4 changes: 2 additions & 2 deletions voila/static_file_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class TemplateStaticFileHandler(tornado.web.StaticFileHandler):
/my/prefix/jupyter/voila/templates/base/static/voila.js
Meaning the url portion is not part of the real (absolute path)
For this sytem, we don't need to use the root, since this is handled in the
For this system, we don't need to use the root, since this is handled in the
paths module.
"""
def initialize(self):
Expand Down Expand Up @@ -102,7 +102,7 @@ def initialize(self, whitelist=[], blacklist=[], **kwargs):

def get_absolute_path(self, root, path):
# StaticFileHandler.get always calls this method first, so we use this as the
# place to check the path. Note that now the path seperator is os dependent (\\ on windows)
# place to check the path. Note that now the path separator is os dependent (\\ on windows)
whitelisted = any(re.fullmatch(pattern, path) for pattern in self.whitelist)
blacklisted = any(re.fullmatch(pattern, path) for pattern in self.blacklist)
if not whitelisted:
Expand Down

0 comments on commit 9d89e82

Please sign in to comment.