Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REMOTE ISF] correct sql query and strip identifier #1025

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Abyss-W4tcher
Copy link
Contributor

@Abyss-W4tcher Abyss-W4tcher commented Oct 21, 2023

  • fix missing quotes and parameters order in SQL query
  • strip identifier (banner) from remote ISF, so that it can be matched against dump banners

Closes #1005

@ikelos ikelos merged commit e5d3134 into volatilityfoundation:develop Oct 23, 2023
14 checks passed
@Abyss-W4tcher Abyss-W4tcher deleted the remote_isf branch November 29, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL error when setting the "REMOTE_ISF_URL" constant
2 participants