Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerate duplicate enum values, keep first name that was seen #1062

Merged

Conversation

vobst
Copy link

@vobst vobst commented Dec 14, 2023

Proposed solution for #1060

Copy link
Member

@ikelos ikelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Sorry, I completely missed you submitted this. Happy to go with yours, but if possible please update the associated lookup docstrings as I've done in #1064?

@ikelos ikelos linked an issue Dec 18, 2023 that may be closed by this pull request
@vobst vobst force-pushed the handle-duplicate-enum-value branch from f5b951d to af6cb00 Compare December 19, 2023 08:26
@vobst
Copy link
Author

vobst commented Dec 19, 2023

added the docstring

@vobst vobst force-pushed the handle-duplicate-enum-value branch from af6cb00 to bd96357 Compare December 19, 2023 08:32
Copy link
Member

@ikelos ikelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 5:)

@ikelos ikelos merged commit fdf93f5 into volatilityfoundation:develop Dec 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Enum value in bpf_map_type
2 participants