This repository has been archived by the owner on Apr 18, 2018. It is now read-only.
Directly reference jQuery and not $ #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volmer
suggested changes
Mar 21, 2017
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| * ImageMagick or GraphicsMagick (for MiniMagick); | |||
| * [Bootstrap 3](http://getbootstrap.com/) fully installed in your app. | |||
| * jQuery | |||
There was a problem hiding this comment.
"Bootstrap 3 fully installed in your app" already implies that jQuery is required.
|
|
||
| this.$el = $el; | ||
| this.unsavedChanges = false; | ||
| this.locale = $el.data("bootsy-locale") || $("html").attr("lang"); |
| @@ -10,113 +10,119 @@ | |||
| <a class="btn">Browse</a> | |||
|
|
|||
| */ | |||
| $(function() { | |||
There was a problem hiding this comment.
This is an external dependency, please do not modify it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes this gem's jQuery dependency explicit by adding it to the README plus wraps all JS files which reference jQuery in a self-invoking anonymous function. This is handy if jQuery is in noconflict mode and being used alongside prototype.