Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

[WIP] conventional-commits-and-changelog #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jbmoelker
Copy link
Member

@jbmoelker jbmoelker commented May 24, 2016

Summary

Proposed changes:

  • add commit, changelog and version scripts
  • add functionality description
  • add usage guidelines
  • add contribution guidelines describing commit format
  • add placeholder changelog

Checklist

  • The changes only affect or contain one recipe.
  • The changes are according to contribution guidelines.
  • The new recipe has an entry in the recipes index (only in case of new recipe).
  • The changes can be merged into the target branch without conflicts.

@jbmoelker
Copy link
Member Author

Work in Progress (WIP) because strangely npm version [major | minor | patch] throws error "nothing to commit". While does work in conventional-changelog-lint. Maybe someone else is able to take a look?

@jpsc
Copy link
Contributor

jpsc commented Jul 25, 2016

It works for me with:

  • npm 3.8.6
  • node 5.12.0

Maybe a specific version bugged ?

@jbmoelker
Copy link
Member Author

@jpsc good to hear. If one more person can verify, maybe we can wrap up this PR :)


## Guidelines

...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be expanded?

@phortuin
Copy link
Member

At the end of the changelog, a line reads:

Note: this changelog is automatically populated using npm run changelog which is used in npm version.

I suppose this is added by default; no way to remove?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants