feature: custom fonts with preloading #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #87. # To do - [ ] add docs (assets/fonts/README.md?) - [ ] use swap with Fontaine?
Deploying head-start with
|
| Latest commit: |
f43745e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d35891e5.head-start.pages.dev |
| Branch Preview URL: | https://feat-87-custom-fonts.head-start.pages.dev |
jbmoelker
commented
Nov 9, 2024
jbmoelker
commented
Nov 9, 2024
| }, | ||
| ]; | ||
|
|
||
| export const getFontCss = (font: Font) => { |
There was a problem hiding this comment.
Note: import raw (import archivo400css from '@fontsource/archivo/latin-400.css?raw';) is not an option as it results in font urls starting with ./files/... that are not resolved. So instead we generate the font declaration ourselves with the url that is resolved correctly in production.
Note 2: I've left out font-display: swap; as we don't have a fallback yet that doesn't cause a layout shift. See to do on Fontaine and font swap.
There was a problem hiding this comment.
Using fontaine seems a bit involved. Rather keep this PR small and merge this first, to add font swap as perf enhancement in a separate PR.
jbmoelker
commented
Nov 9, 2024
4 tasks
jbmoelker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: based on #208 so the
<PerfHead>could easily be extended.Associated issue
Resolves #87
How to test
Checklist
I have made updated relevant documentation files (in project README, docs/, etc)created follow-up issue Document assets setup #210I have added a decision log entry if the change affects the architecture or changes a significant technology