Remove non-essential public certificate attributes #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following certificate attributes have no use in the encryption or decryption process as it is implemented in hiera-eyaml: - subject - version - digest type - extensions These attributes are required when executing with JRuby to sign the certificate: - begin date - end date The attributes that are always essential are the serial number and the public key. When left unset, the serial number is generated randomly or set to 0, which is fine in the context of hiera-eyaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following certificate attributes have no use in the encryption or decryption process as it is implemented in hiera-eyaml:
These attributes are required when executing with JRuby to sign the certificate:
The attributes that are always essential are the serial number and the public key. When left unset, the serial number is generated randomly or set to 0, which is fine in the context of hiera-eyaml.