Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#17] Added the configuration parameter 'use-short-cache-path'. #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renkin
Copy link

@renkin renkin commented Feb 5, 2018

Additionally to the configuration parameter 'tmp', this parameter is helpful to avoid too long cache paths under Windows.

This is achieved by shortening the cache path part of the Puppet forge URI to the 7 first digits of its SHA1 checksum (like short Git commit hash approach).

Under Windows this shortening is especially important when you use an alternative Puppet forge with a quite longer URI.

Additionally to the configuration parameter 'tmp', this parameter is helpful to avoid too long cache paths under Windows.

This is achieved by shortening the cache path part of the Puppet forge URI to the 7 first digits of its SHA1 checksum (like short Git commit hash approach).

Under Windows this shortening is especially important when you use an alternative Puppet forge with a quite longer URI.
@uhanisch
Copy link

uhanisch commented Feb 6, 2018

Would love to see it in master branch

@ekohl
Copy link
Member

ekohl commented Feb 6, 2018

At first sight it makes sense but this could use some tests to verify we don't accidentally break it later. Also wondering if we should use sha256 instead since security tightened systems might disallow sha1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants