Require a version when installing from GitHub #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `caddy::version` parameter is only used when `caddy::install_method` is "github", but no error was previously raised if the user set a specific version that was ignored, and the resulting configuration was not what the user expected. In order to avoid confusion, do not default to an outdated version of caddy when installing from GitHub (requiring the user to explicily tell which version they want) and raise an error if a version is set but is ignored. This should make the module more user-friendly for new users.
jay7x
approved these changes
Nov 30, 2024
|
@smortex I approved the PR, feel free to merge (or ping me if anything, as I'm going to work on this module it seems) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
caddy::versionparameter is only used whencaddy::install_methodis "github", but no error was previously raised if the user set a specific version that was ignored, and the resulting configuration was not what the user expected.In order to avoid confusion, do not default to an outdated version of caddy when installing from GitHub (requiring the user to explicitly tell which version they want) and raise an error if a version is set but is ignored.
This should make the module more user-friendly for new users.
Fixes #94