Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #653 - Wrong ci-repo URL for 'master' #863

Closed
wants to merge 3 commits into from

Conversation

sgi-tschaller
Copy link

Many thanks for the puppet-collectd module. It is magnificent, and I hope that you find this PR worthy. :)

Pull Request (PR) description

when the ci_package_repo is set to 'master' an incorrect 'collectd-' was prepended. This patch changes that.

This Pull Request (PR) fixes the following issues

Fixes #653

@alexjfisher
Copy link
Member

Thanks. I was about to merge this, but I think this needs fixing for Debian too.
I've quickly thrown together #864. I've marked it WIP, as I've not actually tested it yet! Let me know if it works for you.

@bastelfreak bastelfreak added needs-rebase bug Something isn't working and removed needs-rebase labels Jun 16, 2019
@@ -2,10 +2,17 @@

if $::collectd::ci_package_repo {

# Fix for issue #653
if $::collectd::ci_package_repo != 'master' {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't add :: directly after $

@vox-pupuli-tasks
Copy link

Dear @sgi-tschaller, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @sgi-tschaller, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@bastelfreak
Copy link
Member

Hi, I'm going to close this PR due to inactivity. Please reopen it if you're still interested.

@bastelfreak bastelfreak closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge-conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collectd::ci_package_repo = 'master' builds wrong yum repo URL
4 participants