added some unsafe rubocop fixes

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-08-23 17:58:31 UTC using RuboCop version 1.54.2.
+# on 2023-08-26 05:38:06 UTC using RuboCop version 1.54.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -77,7 +77,7 @@ RSpec/RepeatedDescription:
   Exclude:
     - 'spec/puppet-lint/plugins/ghostbuster_facts_spec.rb'
 
-# Offense count: 13
+# Offense count: 9
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -91,13 +91,9 @@ Style/ClassAndModuleChildren:
     - 'lib/puppet-lint/plugins/check_ghostbuster_hiera_files.rb'
     - 'lib/puppet-lint/plugins/check_ghostbuster_templates.rb'
     - 'lib/puppet-lint/plugins/check_ghostbuster_types.rb'
-    - 'spec/fixtures/modules/foo/lib/puppet/parser/functions/bar.rb'
-    - 'spec/fixtures/modules/foo/lib/puppet/parser/functions/baz.rb'
-    - 'spec/fixtures/modules/foo/lib/puppet/parser/functions/foo.rb'
-    - 'spec/fixtures/modules/foo/lib/puppet/parser/functions/quux.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 3
+# Offense count: 5
 Style/ClassVars:
   Exclude:
     - 'lib/puppet-ghostbuster/puppetdb.rb'
@@ -118,12 +114,23 @@ Style/Documentation:
     - 'lib/puppet-lint/plugins/check_ghostbuster_templates.rb'
     - 'lib/puppet-lint/plugins/check_ghostbuster_types.rb'
 
-# Offense count: 33
+# Offense count: 11
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
-  Enabled: false
+  Exclude:
+    - 'lib/puppet-ghostbuster/puppetdb.rb'
+    - 'lib/puppet-ghostbuster/version.rb'
+    - 'lib/puppet-lint/plugins/check_ghostbuster_classes.rb'
+    - 'lib/puppet-lint/plugins/check_ghostbuster_defines.rb'
+    - 'lib/puppet-lint/plugins/check_ghostbuster_facts.rb'
+    - 'lib/puppet-lint/plugins/check_ghostbuster_files.rb'
+    - 'lib/puppet-lint/plugins/check_ghostbuster_functions.rb'
+    - 'lib/puppet-lint/plugins/check_ghostbuster_hiera_files.rb'
+    - 'lib/puppet-lint/plugins/check_ghostbuster_templates.rb'
+    - 'lib/puppet-lint/plugins/check_ghostbuster_types.rb'
+    - 'spec/spec_helper.rb'
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
 gemspec

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)

puppet-ghostbuster.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift File.expand_path('lib', __dir__)
 require 'puppet-ghostbuster/version'
 

spec/fixtures/modules/foo/lib/facter/bar.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Fact used in manifest
 Facter.add('bar') do
   setcode do

spec/fixtures/modules/foo/lib/facter/baz.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Fact used in template
 Facter.add('baz') do
   setcode do

spec/fixtures/modules/foo/lib/facter/foo.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Fact used in a string
 Facter.add('foo') do
   setcode do

spec/fixtures/modules/foo/lib/facter/multi.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Unused facts
 Facter.add('multi1') do
   setcode do

spec/fixtures/modules/foo/lib/facter/quux.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Fact used in inline_template
 Facter.add('quux') do
   setcode do

spec/fixtures/modules/foo/lib/puppet/parser/functions/bar.rb

@@ -1,4 +1,10 @@
-module Puppet::Parser::Functions
-  newfunction(:bar, type: :rvalue) do |arguments|
+# frozen_string_literal: true
+
+module Puppet
+  module Parser
+    module Functions
+      newfunction(:bar, type: :rvalue) do |arguments|
+      end
+    end
   end
 end

spec/fixtures/modules/foo/lib/puppet/parser/functions/baz.rb

@@ -1,4 +1,10 @@
-module Puppet::Parser::Functions
-  newfunction(:baz, type: :rvalue) do |arguments|
+# frozen_string_literal: true
+
+module Puppet
+  module Parser
+    module Functions
+      newfunction(:baz, type: :rvalue) do |arguments|
+      end
+    end
   end
 end

spec/fixtures/modules/foo/lib/puppet/parser/functions/foo.rb

@@ -1,4 +1,10 @@
-module Puppet::Parser::Functions
-  newfunction(:foo, type: :rvalue) do |arguments|
+# frozen_string_literal: true
+
+module Puppet
+  module Parser
+    module Functions
+      newfunction(:foo, type: :rvalue) do |arguments|
+      end
+    end
   end
 end

spec/fixtures/modules/foo/lib/puppet/parser/functions/quux.rb

@@ -1,4 +1,10 @@
-module Puppet::Parser::Functions
-  newfunction(:quux, type: :rvalue) do |arguments|
+# frozen_string_literal: true
+
+module Puppet
+  module Parser
+    module Functions
+      newfunction(:quux, type: :rvalue) do |arguments|
+      end
+    end
   end
 end

spec/fixtures/modules/foo/lib/puppet/type/bar.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 Puppet::Type.newtype(:bar) do
 end

spec/fixtures/modules/foo/lib/puppet/type/foo.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 Puppet::Type.newtype(:foo) do
 end

spec/puppet-lint/plugins/ghostbuster_classes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'ghostbuster_classes' do

spec/puppet-lint/plugins/ghostbuster_defines_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'ghostbuster_defines' do

spec/puppet-lint/plugins/ghostbuster_facts_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'ghostbuster_facts' do

spec/puppet-lint/plugins/ghostbuster_files_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'ghostbuster_files' do

spec/puppet-lint/plugins/ghostbuster_functions_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'ghostbuster_functions' do

spec/puppet-lint/plugins/ghostbuster_hiera_files_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 ENV['HIERA_YAML_PATH'] = './spec/fixtures/hiera.yaml'

spec/puppet-lint/plugins/ghostbuster_templates_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'ghostbuster_templates' do

spec/puppet-lint/plugins/ghostbuster_types_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe 'ghostbuster_types' do