Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #76

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Release 1.0.0 #76

merged 3 commits into from
Nov 11, 2023

Conversation

marek130
Copy link
Contributor

@marek130 marek130 commented Nov 7, 2023

Update version.rb and CHANGELOG.md

@marek130
Copy link
Contributor Author

marek130 commented Nov 7, 2023

@zilchms can we release a new version? many thanks!

@zilchms
Copy link
Contributor

zilchms commented Nov 9, 2023

Sure thing :)
Do you see any reason to make this release a major release? As far as i can tell, there have only been non-breaking enhancements and therefore the new version should be 0.10.0, right?

@marek130
Copy link
Contributor Author

@zilchms great question :) Even it is a small update, from my point of view, moving from Hiera v3 to v5 is significat change in terms of backward-incompatible.

If you were able to use the hiera check in 0.9.0 version it will not be possible with this update. There is totally diferent structure of hiera.yaml.

For example, every path in hierarchy is value of the key ‘path’ or ‘paths’.

@zilchms
Copy link
Contributor

zilchms commented Nov 10, 2023

can you recreate the changelog again? i changed the label of the PR to correctly reflect the changes made

@zilchms
Copy link
Contributor

zilchms commented Nov 10, 2023

sorry to ask again, can you regenerate it a second time? still getting used to doing releases properly...

@marek130
Copy link
Contributor Author

sorry to ask again, can you regenerate it a second time? still getting used to doing releases properly...

There is no big difference after I regenerated again.. Only this:

-## [1.0.0](https://github.com/voxpupuli/puppet-ghostbuster/tree/1.0.0) (2023-11-10)
+## [1.0.0](https://github.com/voxpupuli/puppet-ghostbuster/tree/1.0.0) (2023-11-11)

@zilchms
Copy link
Contributor

zilchms commented Nov 11, 2023

yea, error on my part. no second regenerate needed. sorry about that

@zilchms zilchms merged commit ffcc3c3 into voxpupuli:master Nov 11, 2023
6 checks passed
@zilchms
Copy link
Contributor

zilchms commented Nov 11, 2023

will take a bit until the gem is available, need to get someone with higher permissions to trigger a full gem release :)

@marek130
Copy link
Contributor Author

Many thanks anyway!

@zilchms
Copy link
Contributor

zilchms commented Nov 15, 2023

For reference: a official release of the ruby gem is blocked by #66 which was only partly completed.

@zilchms
Copy link
Contributor

zilchms commented Jan 15, 2024

last update on this: release is now out as migration is fully completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants